Skip to content

[SPARK-13025] Allow users to set initial model in logistic regression - #11459

Closed
GayathriMurali wants to merge 1 commit into
apache:masterfrom
GayathriMurali:SPARK13025
Closed

[SPARK-13025] Allow users to set initial model in logistic regression#11459
GayathriMurali wants to merge 1 commit into
apache:masterfrom
GayathriMurali:SPARK13025

Conversation

@GayathriMurali

Copy link
Copy Markdown
Contributor

JIRA : SPARK - 13025

Modified access specifier to default(Public) to allow users to set initial model in logistic regression

@sethah

Copy link
Copy Markdown
Contributor

Could you update the title with the Jira number? See here for more details.

@GayathriMuraliGayathriMurali changed the title Allow users to set initial model in logistic regression[SPARK-13025] Allow users to set initial model in logistic regressionMar 2, 2016
@GayathriMurali

Copy link
Copy Markdown
ContributorAuthor

Can someone review this?

@jkbradley

Copy link
Copy Markdown
Member

This will be nice to have, but we should make initialModel be a Param

@GayathriMurali

Copy link
Copy Markdown
ContributorAuthor

@jkbradley initialModel is an instance of LogisticRegressionModel, I am not sure if I understand how to make it a Param?

@sethah

Copy link
Copy Markdown
Contributor

Should this wait until PR-11119 is merged?

@GayathriMurali

Copy link
Copy Markdown
ContributorAuthor

@jkbradley are we waiting to get this merged until PR-11119?

@jkbradley

Copy link
Copy Markdown
Member

Sorry for the delayed review. I'm worried that these PRs to set the initial model may need to change significantly if we merge Estimator & Model: [https://issues.apache.org/jira/browse/SPARK-14033] After the merge, setting an initial model may make less sense, for it would then be easier to copy the initial model and set some Boolean parameter indicating that fitting should begin from the current model.

@SparkQA

Copy link
Copy Markdown

Test build #66726 has finished for PR 11459 at commit ab05aa6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

Copy link
Copy Markdown
Member

Hi all, where are we on this?

@sethah

Copy link
Copy Markdown
Contributor

This can be closed.

@HyukjinKwonHyukjinKwon mentioned this pull request Jun 7, 2017
@asfgitasfgit closed this in b771fedJun 8, 2017
@lanisyutin

Copy link
Copy Markdown

Hi, all, what about the status of this issue? why it was not merged? There are any ways to set initialWeights now?

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
# What changes were proposed in this pull request?
This PR proposes to close stale PRs, mostly the same instances with apache#18017Closesapache#11459Closesapache#13833Closesapache#13720Closesapache#12506Closesapache#12456Closesapache#12252Closesapache#17689Closesapache#17791Closesapache#18163Closesapache#17640Closesapache#17926Closesapache#18163Closesapache#12506Closesapache#18044Closesapache#14036Closesapache#15831Closesapache#14461Closesapache#17638Closesapache#18222
Added:
Closesapache#18045Closesapache#18061Closesapache#18010Closesapache#18041Closesapache#18124Closesapache#18130Closesapache#12217
Added:
Closesapache#16291Closesapache#17480Closesapache#14995
Added:
Closesapache#12835Closesapache#17141
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18223 from HyukjinKwon/close-stale-prs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@GayathriMurali@sethah@jkbradley@SparkQA@HyukjinKwon@lanisyutin