Uh oh!
There was an error while loading. Please reload this page.
[SPARK-20378][CORE][SQL][SS] StreamSinkProvider should provide schema in createSink - #17689
Closed
ymahajan wants to merge 1 commit into
Closed
[SPARK-20378][CORE][SQL][SS] StreamSinkProvider should provide schema in createSink#17689ymahajan wants to merge 1 commit into
ymahajan wants to merge 1 commit into
Conversation
AmplabJenkins
commented
Apr 19, 2017
Can one of the admins verify this patch? |
felixcheung
commented
Apr 20, 2017
Member
should this be |
ymahajan
commented
Apr 20, 2017
Author
@felixcheung Thanks, I changed it to [SS] in the subject of this PR. |
| @InterfaceStability.Unstable | ||
| trait StreamSinkProvider { | ||
| def createSink( | ||
| schema: StructType, |
Member
There was a problem hiding this comment.
The interface can't just be changed like this. This breaks backwards compatibility ...
HyukjinKwon
commented
Jun 2, 2017
Member
ping @ymahajan |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
# What changes were proposed in this pull request? This PR proposes to close stale PRs, mostly the same instances with apache#18017Closesapache#11459Closesapache#13833Closesapache#13720Closesapache#12506Closesapache#12456Closesapache#12252Closesapache#17689Closesapache#17791Closesapache#18163Closesapache#17640Closesapache#17926Closesapache#18163Closesapache#12506Closesapache#18044Closesapache#14036Closesapache#15831Closesapache#14461Closesapache#17638Closesapache#18222 Added: Closesapache#18045Closesapache#18061Closesapache#18010Closesapache#18041Closesapache#18124Closesapache#18130Closesapache#12217 Added: Closesapache#16291Closesapache#17480Closesapache#14995 Added: Closesapache#12835Closesapache#17141 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18223 from HyukjinKwon/close-stale-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provided schema in StreamSinkProvider#createSink for custom Sink implementations.
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.