Skip to content

[SPARK-16124][SQL] fix getHiveFile return file url in jar that cannot be load in SQL - #13833

Closed
tilumi wants to merge 1 commit into
apache:masterfrom
tilumi:fix_spark_16124
Closed

[SPARK-16124][SQL] fix getHiveFile return file url in jar that cannot be load in SQL#13833
tilumi wants to merge 1 commit into
apache:masterfrom
tilumi:fix_spark_16124

Conversation

@tilumi

Copy link
Copy Markdown

What changes were proposed in this pull request?

I create a temp file from output stream of the file in jar and return that file

How was this patch tested?

manual tests

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@@ -180,7 +181,12 @@ private[hive] class TestHiveSparkSession(
ShutdownHookManager.registerShutdownDeleteDir(hiveFilesTemp)

def getHiveFile(path: String): File = {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestHive is only used for our unit testing.

@gatorsmile

Copy link
Copy Markdown
Member

Thanks for working on it. This does not sound an issue to Spark SQL users. Cloud we close this PR now?

@HyukjinKwon

Copy link
Copy Markdown
Member

+1 for closing.

@HyukjinKwonHyukjinKwon mentioned this pull request Jun 7, 2017
@asfgitasfgit closed this in b771fedJun 8, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
# What changes were proposed in this pull request?
This PR proposes to close stale PRs, mostly the same instances with apache#18017Closesapache#11459Closesapache#13833Closesapache#13720Closesapache#12506Closesapache#12456Closesapache#12252Closesapache#17689Closesapache#17791Closesapache#18163Closesapache#17640Closesapache#17926Closesapache#18163Closesapache#12506Closesapache#18044Closesapache#14036Closesapache#15831Closesapache#14461Closesapache#17638Closesapache#18222
Added:
Closesapache#18045Closesapache#18061Closesapache#18010Closesapache#18041Closesapache#18124Closesapache#18130Closesapache#12217
Added:
Closesapache#16291Closesapache#17480Closesapache#14995
Added:
Closesapache#12835Closesapache#17141
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18223 from HyukjinKwon/close-stale-prs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tilumi@AmplabJenkins@gatorsmile@HyukjinKwon