Uh oh!
There was an error while loading. Please reload this page.
[SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a fetchSize - #18515
Closed
maver1ck wants to merge 1 commit into
Closed
[SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a fetchSize#18515maver1ck wants to merge 1 commit into
maver1ck wants to merge 1 commit into
Conversation
srowen
commented
Jul 3, 2017
Member
See JIRA; I don't think we should allow this. |
SparkQA
commented
Jul 3, 2017
Test build #79100 has finished for PR 18515 at commit
|
| val fetchSize = { | ||
| val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt | ||
| require(size >= 0, | ||
| require(size >= 0 || size == Integer.MIN_VALUE, |
Member
There was a problem hiding this comment.
It does not make sense to the other data sources except MySQL. If needed, we can introduce a dialect specific checking APIs in JdbcDialect.scala
gatorsmile
commented
Jul 13, 2017
Member
@maver1ck Any update? |
SparkQA
commented
Sep 6, 2017
Test build #81467 has finished for PR 18515 at commit
|
srowen added a commit
to srowen/spark
that referenced
this pull request
Sep 12, 2017
Closesapache#18522Closesapache#17722Closesapache#18879Closesapache#18891Closesapache#18806Closesapache#18948Closesapache#18949Closesapache#19070Closesapache#19039Closesapache#19142Closesapache#18515Closesapache#19154Closesapache#19162Closesapache#19187
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
Closesapache#18522Closesapache#17722Closesapache#18879Closesapache#18891Closesapache#18806Closesapache#18948Closesapache#18949Closesapache#19070Closesapache#19039Closesapache#19142Closesapache#18515Closesapache#19154Closesapache#19162Closesapache#19187Closesapache#19091 Author: Sean Owen <sowen@cloudera.com> Closesapache#19203 from srowen/CloseStalePRs3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
FIX for https://issues.apache.org/jira/browse/SPARK-21287
How was this patch tested?
Existing automated tests + manual tests.