Uh oh!
There was an error while loading. Please reload this page.
When the number of attempting to restart receiver greater than 0,spark do nothing in 'else' - #19142
When the number of attempting to restart receiver greater than 0,spark do nothing in 'else'#19142liuxianjiao wants to merge 1 commit into
Conversation
…r than 0,spark do nothing in 'else'
AmplabJenkins
commented
Sep 6, 2017
Can one of the admins verify this patch? |
srowen
commented
Sep 6, 2017
I don't think this is worthwhile. |
liuxianjiao
commented
Sep 6, 2017
@srowen |
jerryshao
commented
Sep 8, 2017
I'm -1 on this PR. This PR actually fix nothing instead of adding one trace log, also usually user will not enable trace log, so this one line fix is not so helpful. You can find many place in Spark where it has no "else" branch, are you going to fix them all? |
liuxianjiao
commented
Sep 8, 2017
@jerryshao so,what's the meaning of these empty 'else'? |
jerryshao
commented
Sep 8, 2017
NVM, I mean in the Spark code there're some intended empty "else" branch, are you going to add trace log to them all? |
Closesapache#18522Closesapache#17722Closesapache#18879Closesapache#18891Closesapache#18806Closesapache#18948Closesapache#18949Closesapache#19070Closesapache#19039Closesapache#19142Closesapache#18515Closesapache#19154Closesapache#19162Closesapache#19187
Closesapache#18522Closesapache#17722Closesapache#18879Closesapache#18891Closesapache#18806Closesapache#18948Closesapache#18949Closesapache#19070Closesapache#19039Closesapache#19142Closesapache#18515Closesapache#19154Closesapache#19162Closesapache#19187Closesapache#19091 Author: Sean Owen <sowen@cloudera.com> Closesapache#19203 from srowen/CloseStalePRs3.
When the number of attempting to restart receiver greater than 0,spark do nothing in 'else'.So I think we should log trace to let users know why.