Skip to content

[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of [SparkSQL::lP] - #18879

Closed
liu-zhaokun wants to merge 2 commits into
apache:masterfrom
liu-zhaokun:master0808
Closed

[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of [SparkSQL::lP] #18879
liu-zhaokun wants to merge 2 commits into
apache:masterfrom
liu-zhaokun:master0808

Conversation

@liu-zhaokun

@liu-zhaokunliu-zhaokun commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SPARK-21662
As it says "If user doesn't specify the appName, we want to get [SparkSQL::localHostName]" in SparkSqlEnv.scala,line 38,appname should be SparkSQL::localHostName,but it is SparkSQL::lP in fact.So I modify the localHostName method to get localhost with getCanonicalHostName method.

@liu-zhaokun

liu-zhaokun commented Aug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

Can one of the admins verify this patch?

@jiangxb1987

jiangxb1987 commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

I'm not convinced this deserves a separated PR because it's neither bugfix nor any improvement. Further more, the method Utils.localHostName() is used in many other places, we can't change this unless we have investigated on each place it appears.

@srowen

srowen commented Aug 9, 2017

Copy link
Copy Markdown
Member

The method name is misleading internally, but we can't change this logic.

@liu-zhaokun

liu-zhaokun commented Aug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@srowen@jiangxb1987
If we can't change this logic,I think we should change the annotation,because it says "If user doesn't specify the appName, we want to get [SparkSQL::localHostName]" ,it isn't in line with the facts.

@liu-zhaokun

liu-zhaokun commented Aug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@srowen
I have modified the annotation,would you like to review it?

srowen
srowen reviewed Aug 9, 2017
View reviewed changes
Comment threadsql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
if (sqlContext == null) {
val sparkConf = new SparkConf(loadDefaults = true)
// If user doesn't specify the appName, we want to get [SparkSQL::localHostName] instead of
// If user doesn't specify the appName, we will get [SparkSQL::IP] instead of

@srowensrowenAug 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is SparkSQL::IP?
I think this is not worth a JIRA / PR relative to the time spent looking at it
What problem does this cause a user?

@liu-zhaokunliu-zhaokunAug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen
It is not accurate,because the comment is different from the appname in web UI.

@jiangxb1987

jiangxb1987 commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

I think @srowen means you should change the method name, not only the comment.

@liu-zhaokun

liu-zhaokun commented Aug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

Thanks for your patience.Would you @srowen agree with @jiangxb1987 .

@liu-zhaokun

liu-zhaokun commented Aug 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@jiangxb1987
BTW,how to find the release branch of Hive-0.13.1a which spark1.4.1 compiled with?

srowen added a commit to srowen/spark that referenced this pull request Sep 12, 2017
@srowen
Close stale PRs.
6386e0c
Closesapache#18522Closesapache#17722Closesapache#18879Closesapache#18891Closesapache#18806Closesapache#18948Closesapache#18949Closesapache#19070Closesapache#19039Closesapache#19142Closesapache#18515Closesapache#19154Closesapache#19162Closesapache#19187
@srowensrowen mentioned this pull request Sep 12, 2017
Closed
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
@srowen@zifeif2
[BUILD] Close stale PRs
4223075
Closesapache#18522Closesapache#17722Closesapache#18879Closesapache#18891Closesapache#18806Closesapache#18948Closesapache#18949Closesapache#19070Closesapache#19039Closesapache#19142Closesapache#18515Closesapache#19154Closesapache#19162Closesapache#19187Closesapache#19091
Author: Sean Owen <sowen@cloudera.com>
Closesapache#19203 from srowen/CloseStalePRs3.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowensrowensrowen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liu-zhaokun@jiangxb1987@srowen