Skip to content

TEZ-4329. Import external tez component em-table - #146

Merged
jteagles merged 1 commit into
apache:masterfrom
jteagles:TEZ-4329
Aug 26, 2021
Merged

TEZ-4329. Import external tez component em-table#146
jteagles merged 1 commit into
apache:masterfrom
jteagles:TEZ-4329

Conversation

@jteagles

Copy link
Copy Markdown
Contributor

Co-authored-by: Sreenath Somarajapuram sree@apache.org

Co-authored-by: Sreenath Somarajapuram <sree@apache.org>
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec12m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 29smaster passed
+1 💚javadoc0m 47smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 20smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Patch Compile Tests _
+1 💚mvninstall1m 30sthe patch passed
+1 💚jshint39m 52sThere were no new jshint issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 18sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 22sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Other Tests _
+1 💚unit2m 29stez-ui in the patch passed.
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
75m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-146/1/artifact/out/Dockerfile
GITHUB PR#146
Optional Testsdupname asflicense javac javadoc unit jshint
unameLinux 3e7f0724518d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / e2c4ee0
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-146/1/testReport/
Max. process+thread count93 (vs. ulimit of 5500)
modulesC: tez-ui U: tez-ui
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-146/1/console
versionsgit=2.25.1 maven=3.6.3 jshint=2.12.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

patch looks very similar to em-helpers import, LGTM
+1

@abstractdog
abstractdog self-requested a review August 26, 2021 08:29
@abstractdog

Copy link
Copy Markdown
Contributor

1 minor thing before merging, please take a look at this comment: #147 (comment)

@jteagles
jteagles merged commit 0ccf440 into apache:masterAug 26, 2021
@jteagles
jteagles deleted the TEZ-4329 branch August 26, 2021 14:14
jteagles added a commit to jteagles/tez that referenced this pull request Oct 25, 2021
Co-authored-by: Sreenath Somarajapuram <sree@apache.org>
(cherry picked from commit 0ccf440)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jteagles@tez-yetus@abstractdog