TEZ-4330. Import external tez component em-tgraph by jteagles · Pull Request #147 · apache/tez

jteagles · 2021-08-25T18:35:34Z

Co-authored-by: Sreenath Somarajapuram sree@apache.org

tez-yetus · 2021-08-25T18:50:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	12m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	jshint	0m 6s	There were no new jshint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	1m 3s	The patch does not generate ASF License warnings.
		14m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/1/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense jshint
uname	Linux a3c2f5e528b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `e2c4ee0`
Max. process+thread count	51 (vs. ulimit of 5500)
modules	C: tez-ui U: tez-ui
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/1/console
versions	git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2021-08-26T08:31:50Z

 import Ember from 'ember';

 import MultiTableController from '../multi-table';
-import ColumnDefinition from 'em-table/utils/column-definition';


shouldn't this be part of em-table import, which is TEZ-4329?

Thanks. This change was in em-table PR as well. I'm glad you caught this accidental import. I'll merge em-table and then audit the list of imports to make sure we are good.

@sreenaths / @abstractdog updated to fix import. should be ready for review again

tez-yetus · 2021-08-26T16:47:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	jshint	0m 6s	There were no new jshint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 59s	The patch does not generate ASF License warnings.
		2m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/2/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense jshint
uname	Linux 665a9c424f87 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `0ccf440`
Max. process+thread count	51 (vs. ulimit of 5500)
modules	C: tez-ui U: tez-ui
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/2/console
versions	git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus · 2021-08-26T18:00:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	12m 42s	master passed
+1 💚	javadoc	0m 44s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 22s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 21s	the patch passed
+1 💚	jshint	52m 35s	There were no new jshint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 21s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 20s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Other Tests _
+1 💚	unit	1m 52s	tez-ui in the patch passed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		72m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense javac javadoc unit jshint
uname	Linux 974ec6de6131 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `0ccf440`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/testReport/
Max. process+thread count	93 (vs. ulimit of 5500)
modules	C: tez-ui U: tez-ui
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/3/console
versions	git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Co-authored-by: Sreenath Somarajapuram <sree@apache.org>

tez-yetus · 2021-08-26T21:01:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	12m 54s	master passed
+1 💚	javadoc	0m 45s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 20s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 31s	the patch passed
+1 💚	jshint	56m 18s	There were no new jshint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 18s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 20s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
		_ Other Tests _
+1 💚	unit	2m 2s	tez-ui in the patch passed.
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		76m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense javac javadoc unit jshint
uname	Linux 2381fcf8a5f9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / `0ccf440`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/testReport/
Max. process+thread count	92 (vs. ulimit of 5500)
modules	C: tez-ui U: tez-ui
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-147/4/console
versions	git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

abstractdog · 2021-10-19T09:17:35Z

my previous comment was addressed, other than that this is mostly a copy from another repo (I mean don't have to read it line-by-line), precommit is green, so it's a +1 from my side
please let us know @sreenaths if you found any problems, otherwise I'll merge this and maybe go for mock-ats

abstractdog requested changes Aug 26, 2021
View reviewed changes

abstractdog mentioned this pull request Aug 26, 2021
TEZ-4329. Import external tez component em-table #146
Merged

jteagles force-pushed the TEZ-4330 branch from 3cfa611 to adb3a75Compare August 26, 2021 16:44

jteagles force-pushed the TEZ-4330 branch from adb3a75 to 7289494Compare August 26, 2021 16:47

TEZ-4330. Import external tez component em-tgraph
fd3b06c
Co-authored-by: Sreenath Somarajapuram <sree@apache.org>

jteagles force-pushed the TEZ-4330 branch from 7289494 to fd3b06cCompare August 26, 2021 19:44

tez-yetus mentioned this pull request Sep 3, 2021
TEZ-4334: Resolve deadlock in ShuffleScheduler which occurs when ShufflePenaltyReferee waits for the lock of ShuffleScheduler #150
Closed

tez-yetus mentioned this pull request Oct 1, 2021
TEZ-4338: Tez should consider node information to realize OUTPUT_LOST as early as possible - upstream(mapper) problems #152
Merged

tez-yetus mentioned this pull request Oct 14, 2021
TEZ-4180: Show convenient input -> output vertex names in output/sort messages #154
Merged

abstractdog self-requested a review October 19, 2021 09:17

abstractdog approved these changes Oct 19, 2021
View reviewed changes

tez-yetus mentioned this pull request Nov 14, 2021
TEZ-4350: Remove synchronized from DAGAppMaster.serviceInit #162
Merged

tez-yetus mentioned this pull request Dec 3, 2021
TEZ-4357: Report url to logs in case of fetcher connection failure #169
Merged

This was referenced Apr 14, 2025
Tez: Migrating to JDK17 #405
Closed
TEZ-4624: Replace findbugs plugin with spotbugs #406
Closed
TEZ-4598: JDK-17: Migrate Tez to jdk17 (compile & runtime) #407
Merged
TEZ-4014: Allow DAGAppMaster to read configuration from plaintext (1/3) #408
Merged

This was referenced Apr 27, 2025
TEZ-4625: Yetus upgrade to 0.15.1 version #409
Merged
TEZ-4624: Replace findbugs plugin with spotbugs #410
Merged
TEZ-4626: Remove usage of deprecated classes of commons-cli #411
Merged

tez-yetus mentioned this pull request May 7, 2025
[Do not Review] PR raised for to check spotbugs report and precommits after jdk17 merge #413
Closed

tez-yetus mentioned this pull request May 16, 2025
TEZ-4631: Include an official script that installs hadoop and tez and runs a simple example DAG #414
Merged

This was referenced May 29, 2025
TEZ-4627: Apache Tez Release 0.10.5 - update DOAP file #415
Merged
TEZ-4627: Apache Tez Release 0.10.5 - site markdown changes #416
Merged

tez-yetus mentioned this pull request Jun 17, 2025
TEZ-4636: Move to JDK-21+ #418
Merged

Navigation Menu

Uh oh!

TEZ-4330. Import external tez component em-tgraph - #147

TEZ-4330. Import external tez component em-tgraph#147
jteagles wants to merge 1 commit into
apache:masterfrom
jteagles:TEZ-4330

jteagles commented Aug 25, 2021

Uh oh!

tez-yetus commented Aug 25, 2021

Uh oh!

abstractdogAug 26, 2021

Uh oh!

sreenathsAug 26, 2021

Uh oh!

jteaglesAug 26, 2021

Uh oh!

jteaglesAug 26, 2021

Uh oh!

tez-yetus commented Aug 26, 2021

Uh oh!

tez-yetus commented Aug 26, 2021

Uh oh!

tez-yetus commented Aug 26, 2021

Uh oh!

abstractdog commented Oct 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jteagles commented Aug 25, 2021

Uh oh!

tez-yetus commented Aug 25, 2021

Uh oh!

abstractdogAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

sreenathsAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

jteaglesAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

jteaglesAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

tez-yetus commented Aug 26, 2021

Uh oh!

tez-yetus commented Aug 26, 2021

Uh oh!

tez-yetus commented Aug 26, 2021

Uh oh!

abstractdog commented Oct 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants