Add support for PP2_SUBTYPE_SSL_GROUP - #12921
Merged
Merged
Conversation
Member
Author
|
[approve ci centos] |
2 similar comments
Member
Author
|
[approve ci centos] |
Member
Author
|
[approve ci centos] |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for the PROXY Protocol v2 TLS sub-TLV PP2_SUBTYPE_SSL_GROUP so that ATS can parse it, expose it via ProxyProtocol, and log it as a first-class log field.
Changes:
- Add
PP2_SUBTYPE_SSL_GROUPconstant andProxyProtocol::get_tlv_ssl_group()accessor. - Add a new logging marshal function and register a new log field (
proxy_protocol_tls_group/pptg). - Extend the Proxy Protocol v2 parser unit test and update logging field documentation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/proxy/logging/LogAccess.cc |
Implements marshaling of the TLS group string from PROXY Protocol context for logging. |
include/proxy/logging/LogAccess.h |
Declares the new marshaling method for the logging subsystem. |
src/proxy/logging/Log.cc |
Registers the new log field proxy_protocol_tls_group with symbol pptg. |
include/iocore/net/ProxyProtocol.h |
Defines PP2_SUBTYPE_SSL_GROUP and declares the new accessor. |
src/iocore/net/ProxyProtocol.cc |
Implements get_tlv_ssl_group() via existing SSL sub-TLV parsing logic. |
src/iocore/net/unit_tests/test_ProxyProtocol.cc |
Updates v2 TLV test fixture lengths and validates parsing of the new SSL group subtype. |
doc/admin-guide/logging/formatting.en.rst |
Documents the new pptg logging field. |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 9, 2026
(cherry picked from commit 37a801a)
cmcfarlen
added a commit
that referenced
this pull request
Jun 9, 2026
PR #12921 (PP2_SUBTYPE_SSL_GROUP) was authored against pre-#13123 master where m_http_sm was accessible directly on LogAccess. On 10.2.x we already picked the LogData refactor (#13124, the 10.2.x-targeted twin of master's #13123), which moves transaction state behind m_data->get_pp_* getters. Rewrite the new marshal function to match the existing marshal_proxy_protocol_tls_cipher / _version pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.