Conversation
This addresses a performance regression added by apache#13059. Malformed pre-transaction logging introduced an extra virtual data interface on the normal access log path. That made every completed transaction pay for indirection that is only needed for rare protocol-layer failures. This replaces the virtual hierarchy with a concrete composed TransactionLogData wrapper. This keeps LogAccess using one data object while routing the common HttpSM path through direct getters and falling back to owned pre-transaction data only when no HttpSM exists. (cherry picked from commit 05a916f)
cmcfarlen
added a commit
that referenced
this pull request
Jun 9, 2026
PR #12921 (PP2_SUBTYPE_SSL_GROUP) was authored against pre-#13123 master where m_http_sm was accessible directly on LogAccess. On 10.2.x we already picked the LogData refactor (#13124, the 10.2.x-targeted twin of master's #13123), which moves transaction state behind m_data->get_pp_* getters. Rewrite the new marshal function to match the existing marshal_proxy_protocol_tls_cipher / _version pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a performance regression added by #13059.
Malformed pre-transaction logging introduced an extra virtual data interface on the normal access log path. That made every completed transaction pay for indirection that is only needed for rare protocol-layer failures.
This replaces the virtual hierarchy with a concrete composed TransactionLogData wrapper. This keeps LogAccess using one data object while routing the common HttpSM path through direct getters and falling back to owned pre-transaction data only when no HttpSM exists.
(cherry picked from commit 05a916f)