Conversation
bneradt
force-pushed
the
fix_malformed_h2_request_logging_performance-codex
branch
from
April 28, 2026 15:10
3f0a198 to
05a916f
Compare
Contributor
Author
|
10.2.x backport: |
This addresses a performance regression added by apache#13059. Malformed pre-transaction logging introduced an extra virtual data interface on the normal access log path. That made every completed transaction pay for indirection that is only needed for rare protocol-layer failures. This replaces the virtual hierarchy with a concrete composed TransactionLogData wrapper. This keeps LogAccess using one data object while routing the common HttpSM path through direct getters and falling back to owned pre-transaction data only when no HttpSM exists.
bneradt
force-pushed
the
fix_malformed_h2_request_logging_performance-codex
branch
from
April 28, 2026 15:34
05a916f to
9c97c94
Compare
cmcfarlen
approved these changes
Apr 29, 2026
cmcfarlen
added a commit
to cmcfarlen/trafficserver
that referenced
this pull request
May 21, 2026
CI Linux build hits a CMake configuration error reporting a cycle between the RESCAN link group and configmanager. configmanager links PRIVATE ts::proxy (a member of the group), and ts::logging in the group links PUBLIC ts::configmanager (added by apache#13123, kept on this trial because it was backported to 10.2.x). On master, the 11-Dev merge restructured configmanager to depend on ts::records instead of ts::proxy, breaking the cycle. This trial reverts that restructuring; adding configmanager into the RESCAN group lets the linker resolve the cycle the same way it does for the other libs in the group. macOS doesn't hit this because its linker takes the non-RESCAN codepath.
cmcfarlen
added a commit
that referenced
this pull request
Jun 9, 2026
PR #12921 (PP2_SUBTYPE_SSL_GROUP) was authored against pre-#13123 master where m_http_sm was accessible directly on LogAccess. On 10.2.x we already picked the LogData refactor (#13124, the 10.2.x-targeted twin of master's #13123), which moves transaction state behind m_data->get_pp_* getters. Rewrite the new marshal function to match the existing marshal_proxy_protocol_tls_cipher / _version pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 29, 2026
This addresses a performance regression added by apache#13059. Malformed pre-transaction logging introduced an extra virtual data interface on the normal access log path. That made every completed transaction pay for indirection that is only needed for rare protocol-layer failures. This replaces the virtual hierarchy with a concrete composed TransactionLogData wrapper. This keeps LogAccess using one data object while routing the common HttpSM path through direct getters and falling back to owned pre-transaction data only when no HttpSM exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a performance regression added by #13059.
Malformed pre-transaction logging introduced an extra virtual data
interface on the normal access log path. That made every completed
transaction pay for indirection that is only needed for rare
protocol-layer failures.
This replaces the virtual hierarchy with a concrete composed
TransactionLogData wrapper. This keeps LogAccess using one data object
while routing the common HttpSM path through direct getters and falling
back to owned pre-transaction data only when no HttpSM exists.