Skip to content

[microTVM][Zephyr] Add 'config_main_stack_size' option to API server - #9026

Merged
areusch merged 11 commits into
apache:mainfrom
mehrdadh:add_stack_api_server
Sep 23, 2021
Merged

[microTVM][Zephyr] Add 'config_main_stack_size' option to API server#9026
areusch merged 11 commits into
apache:mainfrom
mehrdadh:add_stack_api_server

Conversation

@mehrdadh

@mehrdadhmehrdadh commented Sep 16, 2021

Copy link
Copy Markdown
Member
  • When using API server in for external project, sometime we need to set main stack size for zephyr board if model is large. This PR adds this option to Zephyr project API.
  • In addition, this PR moves zephyr board properties to a json file to create a single source for board information for testing purposes.
  • Finally, this PR adds a validation check for projectOption passed to api server.

cc @areusch@gromero

waiting for #9018 before merging this.

@mehrdadhmehrdadh mentioned this pull request Sep 16, 2021
Merged
areusch
areusch requested changes Sep 17, 2021
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mehrdadh

Comment threadapps/microtvm/zephyr/template_project/microtvm_api_server.py Outdated
Comment threadapps/microtvm/zephyr/template_project/microtvm_api_server.py Outdated
Comment threadtests/micro/zephyr/test_zephyr.py Outdated
Comment threadtests/micro/zephyr/conftest.py Outdated
gromero
gromero requested changes Sep 17, 2021
View reviewed changes

@gromerogromero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mehrdadh Thanks for the change. Looks good overall.

Please see my comments inline. And a nit in the title: I think it should be:
[microTVM][Zephyr] Add 'main_stack_size' option to API server

Cheers

Comment threadapps/microtvm/zephyr/template_project/microtvm_api_server.py Outdated
Comment threadapps/microtvm/zephyr/template_project/microtvm_api_server.py Outdated
Comment threadtests/micro/zephyr/test_zephyr.py Outdated
Comment threadpython/tvm/micro/project.py
Comment threadpython/tvm/micro/project.py Outdated
@mehrdadhmehrdadh changed the title [microtvm][Zephyr] Add MAIN_STACK_SIZE option to API server[microTVM][Zephyr] Add 'main_stack_size' option to API serverSep 17, 2021
@mehrdadh

mehrdadh commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

@gromero thanks for the review. I addressed the comments. PTAL.

@mehrdadhmehrdadh reopened this Sep 18, 2021
gromero
gromero requested changes Sep 20, 2021
View reviewed changes

@gromerogromero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehrdadh Thanks for addressing the comments. There is only one remaining issue in the code that was not caught by the CI (PTAL at the inline comments) and a nit in the PR title. Otherwise LGTM.

Comment threadtests/micro/zephyr/test_zephyr.py
Comment threadtests/micro/zephyr/test_zephyr.py
Comment threadapps/microtvm/zephyr/template_project/microtvm_api_server.py
@mehrdadhmehrdadh changed the title [microTVM][Zephyr] Add 'main_stack_size' option to API server[microTVM][Zephyr] Add 'config_main_stack_size' option to API serverSep 20, 2021
@mehrdadhmehrdadh mentioned this pull request Sep 20, 2021
Merged
@mehrdadh

mehrdadh commented Sep 20, 2021

Copy link
Copy Markdown
MemberAuthor

waiting for CI fix: #9050

@gromero

gromero commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

@mehrdadh LGTM, thanks! Once CI is happy with it I'm happy too.

PS: that branch is still failing on disco board on test_autotune_conv2d but the error is not related to the changes in this PR. It seems the error was introduced with AutoTVM patchset. Anyway, I've filed #9049 to keep track of it.

areusch
areusch approved these changes Sep 21, 2021
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehrdadh please fix the CI issue

@mehrdadhmehrdadh mentioned this pull request Sep 21, 2021
Merged
@areusch

areusch commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

blocked on #9013

@areusch
areusch merged commit 73c2845 into apache:mainSep 23, 2021
@mehrdadh
mehrdadh deleted the add_stack_api_server branch September 23, 2021 15:55
gromero pushed a commit to gromero/tvm that referenced this pull request Sep 24, 2021
@mehrdadh@gromero
[microTVM][Zephyr] Add 'config_main_stack_size' option to API server (a…
9f4cc25
…pache#9026)
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@mehrdadh@ylc
[microTVM][Zephyr] Add 'config_main_stack_size' option to API server (a…
23562e9
…pache#9026)
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@mehrdadh@ylc
[microTVM][Zephyr] Add 'config_main_stack_size' option to API server (a…
8997c66
…pache#9026)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@gromerogromerogromero approved these changes
@comaniaccomaniacAwaiting requested review from comaniac
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@liangfuliangfuAwaiting requested review from liangfu
@manupakmanupakAwaiting requested review from manupak
@merrymercymerrymercyAwaiting requested review from merrymercy
@tmoreau89tmoreau89Awaiting requested review from tmoreau89
@tqchentqchenAwaiting requested review from tqchen
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mehrdadh@gromero@areusch