Skip to content

[hot-fix][CI]Disable mypy for ethosu - #9050

Closed
mikepapadim wants to merge 1 commit into
apache:mainfrom
mikepapadim:ci_hot_fix
Closed

[hot-fix][CI]Disable mypy for ethosu#9050
mikepapadim wants to merge 1 commit into
apache:mainfrom
mikepapadim:ci_hot_fix

Conversation

@mikepapadim

Copy link
Copy Markdown
Contributor

Fix for failing CI on ethosu mypy sanity checks

@tqchen@mehrdadh

@tqchen

Copy link
Copy Markdown
Member

cc @manupa-arm

@manupak

Copy link
Copy Markdown
Contributor

Thanks for catching this! Any idea why it did not fail before?

cc: @mbaret @ashutosh-arm

@mikepapadim

Copy link
Copy Markdown
ContributorAuthor

@manupa-arm it looks like the changes causing this one are from here #8806

@manupak

Copy link
Copy Markdown
Contributor

Thanks @mikepapadim! but I believe it passed CI with those checks. Did anything change on the CI ?

@asparkhi

asparkhi commented Sep 20, 2021

Copy link
Copy Markdown
Contributor

Missing stub warnings can be fixed with this:

mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/ --ignore-missing-imports

@areusch

Copy link
Copy Markdown
Contributor

this hit #9013, we also need to fix that.

@AndrewZhaoLuo

Copy link
Copy Markdown
Contributor

Can we set up a big red button that merges something without CI passing?

@mikepapadim

Copy link
Copy Markdown
ContributorAuthor

this hit #9013, we also need to fix that.

This bug hits also stagging Jenkins.

@mikepapadim

Copy link
Copy Markdown
ContributorAuthor

@areusch I think this PR can be closed if #9052 get through.

@junrushao

Copy link
Copy Markdown
Member

i dont think committers have permission to merge a pr without CI green. maybe it's a merge conflict?

@areusch

Copy link
Copy Markdown
Contributor

i think we don't need this anymore. closing, feel free to reopen if we do need it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@mikepapadim@tqchen@manupak@asparkhi@areusch@AndrewZhaoLuo@junrushao