breaking: merge v2 changes into master - #1802

Merged
laurenyu merged 156 commits into
masterfrom
zwei
Aug 4, 2020
Merged

breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom
zwei

Conversation

@laurenyu

@laurenyulaurenyu commented Aug 4, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:
#1459

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

laurenyuand others added 30 commits May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyulaurenyu mentioned this pull request Aug 4, 2020
Merged
7 tasks
metrizable
metrizable previously approved these changes Aug 4, 2020
View reviewed changes

@metrizablemetrizable left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad previously approved these changes Aug 4, 2020
View reviewed changes

@knakadknakad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!

ajaykarpur
ajaykarpur previously approved these changes Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng previously approved these changes Aug 4, 2020
View reviewed changes
@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable
metrizable approved these changes Aug 4, 2020
View reviewed changes

@metrizablemetrizable left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____|

@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu
laurenyu merged commit 64f600d into masterAug 4, 2020
@knikure
knikure deleted the zwei branch November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
breaking: merge v2 changes into master - #1802
Merged
laurenyu merged 156 commits into
masterfrom 
zwei
Aug 4, 2020
Merged
breaking: merge v2 changes into master#1802
laurenyu merged 156 commits into
masterfrom 
zwei
Conversation
@laurenyu
@laurenyulaurenyu
commented
Aug 4, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
#1459
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
laurenyuand others
added 30 commits
May 14, 2020 13:10
@laurenyu
change: create ASTTransformer class to handle migrating Python SDK co…
f7f0ac6
…de for v2 (#1492)
As a start, this class ensures that the framework_version parameter
is specified when framework classes are instantiated.
@laurenyu
change: add class to read Python scripts and update code for v2 (#1497)
81ad62b
@laurenyu
infra: add tools/ dir to pylint check (#1499)
d197b74
@laurenyu
change: add CLI wrapper for v2 migration script (#1500)
88518e0
@laurenyu
change: add .ipynb file support for v2 migration script (#1508)
57b2a22
@laurenyu
breaking: remove estimator parameters for TF legacy mode (#1510)
40f1d75
@laurenyu
change: add v2 migration script to console_scripts in setup.py (#1530)
5b078f7
@laurenyu
breaking: remove legacy TensorFlowModel and TensorFlowPredictor class…
c65c80f
…es (#1531)
This change also removes the associated serialization/deserialization code
used by TensorFlowPredictor and the locally copied TFS APIs.
@laurenyu
change: convert TF legacy mode parameters to hyperparameters in v2 mi…
a680be1
…gration script (#1534)
@laurenyu
infra: add unit tests for v2 migration script file updaters and modif…
614fe7e
…iers (#1536)
@chuyang-deng
change: remove scipy from dependencies (#1518)
6eeca73
@laurenyu
change: make v2 migration script remove legacy run_tensorboard_locall…
0c5392f
…y parameter (#1537)
@laurenyu
breaking: force image_uri to be passed for legacy TF images (#1539)
d0eb4a2
This change also reorganizes the TF unit tests a bit,
and updates the tf_version fixture to include recent versions.
@laurenyu
 breaking: rename sagemaker.tensorflow.serving to sagemaker.tensorflo…
778a4ee
…w.model (#1541)
This changes the following two classes:
* sagemaker.tensorflow.serving.Model --> sagemaker.tensorflow.model.TensorFlowModel
* sagemaker.tensorflow.serving.Predictor --> sagemaker.tensorflow.model.TensorFlowPredictor
This commit also changes two attributes to match the other framework model classes:
* FRAMEWORK_NAME --> __framework_name__
* _framework_version --> framework_version
@laurenyu
change: make v2 migration script remove script_mode param and set mod…
242f81b
…el_dir=False if needed (#1540)
@laurenyu
Merge branch 'master' into zwei
0f5c9b5
@laurenyu
infra: remove TF from optional dependencies (#1548)
3014421
@laurenyu
fix: look for 'sagemaker.tensorflow.estimator' module in v2 migration…
2099a8d
… tool (#1550)
@laurenyu
fix: look for 'sagemaker.<framework>.<estimator/model>' module in v2 …
baf1c35
…migration tool (#1551)
@laurenyu
change: update v2 migration tool to rename TFS classes/imports (#1552)
de54a76
@laurenyu
doc: update TF documentation to reflect breaking changes and how to u…
97cd594
…pgrade (#1547)
@laurenyu
doc: change "v2" to "version 2.0 or later" (#1557)
800f960
@laurenyu
doc: start v2 usage and migration documentation (#1553)
18e402c
@laurenyu
doc: remove documentation about old MXNet training script format (#1560)
7a7c658
@metrizable
breaking: require framework_version, py_version for mxnet (#1559)
09336f7
* breaking: require framework_version, py_version for mxnet
* framework_version, py_version required for framework MXNet
* framework_version, py_version required for framework MXNetModel
* image_name required if either framework_version or py_version None
* re-order of non-default args, convention to follow entry_point
* unit and integ testing updates
* doc updates
* ignore coverage results for py27 env due to v2 migration scripts
@metrizable@chuyang-deng
change: require framework_version, py_version for xgboost (#1570)
5233dfc
* small updates to docstrings
* small updates to tests
Co-authored-by: Chuyang <chuyangdeng@gmail.com>
@metrizable
breaking: require framework_version, py_version for sklearn (#1576)
9977206
@metrizable
breaking: require framework_version, py_version for pytorch (#1568)
7919331
@laurenyu
breaking: change Model parameter order to make model_data optional (#…
9df3f5a
…1579)
@metrizable
breaking: require framework_version, py_version for tensorflow (#1580)
dbdaf50
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99773e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyulaurenyu
mentioned this pull request
Aug 4, 2020
 Merged

7 tasks
metrizable
metrizable
previously approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it
 !
!
^
/ \
/___\
|= =|
| s |
| a |
| g |
| e |
| m |
| a |
| k |
| e |
| r |
| |
/|##!##|\
/ |##!##| \
/ |##!##| \
| / ^ | ^ \ |
| / ( | ) \ |
|/ ( | ) \|
(( ))
(( : ))
(( : ))
(( ))
(( ))
( )
.
.
.

knakad
knakad
previously approved these changes
Aug 4, 2020
View reviewed changes
@knakadknakad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!
ajaykarpur
ajaykarpur
previously approved these changes
Aug 4, 2020
View reviewed changes
chuyang-deng
chuyang-deng
previously approved these changes
Aug 4, 2020
View reviewed changes
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
metrizable
metrizable
approved these changes
Aug 4, 2020
View reviewed changes
@metrizablemetrizable
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!
 ___ |__ \ __ __ ) | \ \ / // / \ V // /_ \_/|____| 
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4a744a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Aug 4, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4a744a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@laurenyu
laurenyu
merged commit 64f600d
into
masterAug 4, 2020
@knikure
knikure
deleted the

zwei

branch
November 3, 2023 00:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


5 more reviewers

@ajaykarpurajaykarpurajaykarpur approved these changes
@chuyang-dengchuyang-dengchuyang-deng approved these changes
@bveeramanibveeramanibveeramani approved these changes
@knakadknakadknakad approved these changes
@metrizablemetrizablemetrizable approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@laurenyu@sagemaker-bot@ajaykarpur@chuyang-deng@bveeramani@knakad@metrizable@IvyBazan