Skip to content

Request sized relay media for avatars - #58

Merged
comp615 merged 1 commit into
block:mainfrom
comp615:media-sizing
Sep 14, 2026
Merged

comp615 merged 1 commit into
block:mainfrom
comp615:media-sizing

Conversation

@comp615

@comp615 comp615 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • request the relay's 320 px thumbnail variant for avatars and avatar prewarming while preserving original media for attachments and custom emoji
  • request the original image when a profile panel opens
  • present profile artwork as a centered, constrained square with details stacked below
  • add a design-system fill avatar size so the feature owns the portrait's dimensions without cross-scope CSS selectors

Before and after

Both screenshots show Charlie Croom's profile at the same 1440×900 viewport. “Before” is origin/main; “After” is this PR's head.

Before (origin/main) After (PR head)
Before on origin/main: small profile avatar with details beside it After on PR head: larger constrained square portrait with details stacked below

Validation

  • just scan main browser matrix: 370 tests passed in Chromium and WebKit
  • Vitest: 1,366 tests passed
  • design browser: 18 tests passed in Chromium and WebKit
  • design type, color, contrast, and component checks passed
  • frontend and design-system builds passed
  • Clippy, plugin-manager tests, and native Rust tests passed
  • pre-push related suite: 679 tests passed

🤖 Implemented and prepared with Amp.

Signed-off-by: Charlie Croom <ccroom@squareup.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0a072-a480-77b8-8f2e-c102da117e5c
Co-authored-by: Amp <amp@ampcode.com>
@comp615
comp615 requested a review from wesbillman as a code owner September 14, 2026 16:35
@comp615
comp615 merged commit 1e16ddc into block:main Sep 14, 2026
12 checks passed
@comp615
comp615 deleted the media-sizing branch September 14, 2026 19:20
delkc added a commit that referenced this pull request Sep 15, 2026
* origin/main:
  Fix inline mention styling in channels (#74)
  Fix self-replenishing background channel warming (#71)
  Add links and thread previews (#42)
  Add shared receive-only channel and thread typing (#33)
  Warm channel heads in the background before they are opened (#54)
  Add Developer settings tab with cache clear and broker stats (#53)
  Request sized relay media for avatars (#58)
  Allow parallel browser development ports (#57)
  Add worktree bootstrap for local configuration (#56)
  Make thread opens part of navigation history (#55)
  Remove the decoded-avatar hot set; respect Save-Data (#60)
  Add CODEOWNERS reviewers (#61)
  Add guarded Workflows page and session capability (#48)

Signed-off-by: Clay Delk <clay.delk@gmail.com>

# Conflicts:
#	dev/relay-broker.mjs
#	src/bundled/channels/ChannelsPage.tsx
#	src/features/messages/ChannelTimeline.tsx
#	src/features/messages/MessageComposer.tsx
#	src/features/messages/MessageRow.tsx
#	src/features/messages/ThreadPanel.test.tsx
#	src/features/messages/ThreadPanel.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants