Fix inline mention styling in channels - #74
Conversation
Signed-off-by: klopez4212 <klopez4212@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31f40625c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| /* Channel hosts reset ordinary buttons to inherited text color. */ | ||
| [data-mention-kind].link { |
There was a problem hiding this comment.
This proposed commit has no Signed-off-by trailer, so it violates the repository’s DCO requirement and will fail the hosted DCO Check; recreate the commit with git commit --signoff using the verified effective author identity.
AGENTS.md reference: AGENTS.md:L98-L106
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No actionable defects found in the inline mention styling change.
Reviewed head 31f40625c6bcbc5098c859ee29dd12244acc0c50 against base 7ce898eb6f77ca4fb95f06a7c7789f63245dee28. The added selector defeats the Channels button-color reset without changing mention layout, focus, activation, or ordinary link styling. The fixture now includes the actual Channels root CSS and compares both delivered mention kinds with a rendered link.
Validation: inspected existing CI logs rather than rerunning broad suites. The composer/link journey and profile interaction journey passed Chromium and WebKit. CI checked merge cff5fd3c861275a2a29c1484b1a0db0ad00b766c; its tree is identical to the reviewed head. git diff --check passed.
Separate CI gate: Chromium shard 2 failed navigation-thread-history.spec.mjs:45, waiting for “Thread root 1” after Back. This is outside the changed mention-color behavior; its cause has not been diagnosed here. CI required remains red. No CI rebuild or native acceptance check performed in this review.
This is a review comment, not a GitHub approval.
* origin/main: Fix inline mention styling in channels (#74) Fix self-replenishing background channel warming (#71) Add links and thread previews (#42) Add shared receive-only channel and thread typing (#33) Warm channel heads in the background before they are opened (#54) Add Developer settings tab with cache clear and broker stats (#53) Request sized relay media for avatars (#58) Allow parallel browser development ports (#57) Add worktree bootstrap for local configuration (#56) Make thread opens part of navigation history (#55) Remove the decoded-avatar hot set; respect Save-Data (#60) Add CODEOWNERS reviewers (#61) Add guarded Workflows page and session capability (#48) Signed-off-by: Clay Delk <clay.delk@gmail.com> # Conflicts: # dev/relay-broker.mjs # src/bundled/channels/ChannelsPage.tsx # src/features/messages/ChannelTimeline.tsx # src/features/messages/MessageComposer.tsx # src/features/messages/MessageRow.tsx # src/features/messages/ThreadPanel.test.tsx # src/features/messages/ThreadPanel.tsx
Summary
Testing