Uh oh!
There was an error while loading. Please reload this page.
Conversation
* made fuzzy mode as default * made fuzzy matching work with `get_alignments` method * added all-merged `typevers` dict to vocab package * made at_type version compat test cases to check for version difference warnings
added "fuzzy" mode to `__eq__` of CLAMS vocab subclasses
* validating output using built-in MMIF jsonschema * remove non-existing annotation types from ``contains`` metadata
* this was a problem mainly because we do not allow an empty `annotations` list while allowing an empty `metadata.contains`. * Mmif._serialize() method ignores any "empty" attributes during serialization, resulting in view.metadata that has neither `contains`, `error`, nor `warnings` when "safe_serializing" a view with an empty `annotations` list. * this implementation inserts an empty dict back to view.metadata as a `contains`
…serialize` of Mmif
adding sanitized `serialize`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This release includes "fuzzy" matching of at_types and sanitized
serializeofMmifobjects.Additions
__eq__check (support "fuzzy" comparison of at_type IRIs (not considering versions) #209 . Fuzzy matching will ignore differences in versions of two at_types, but still issue python warnings when there's a version mismatch. By default, all CLAMS vocab type subclasses are initiated with fuzzy mode "on".Mmif. serializenow supports sanitizing the output JSON (view.metadata.containshave items (at_types) that are not actually inannotationslist #205) . Can be turned on by passingsanitize=Trueargument. Sanitizing will performcontainsmetadataChanges
Mmif.get_alignmentsview.metadataserialized into an invalid MMIF due to a oneOf condition in jsonschema