Skip to content

updating documentation - #355

Merged
keighrim merged 19 commits into
developfrom
348-documentation
Feb 11, 2026
Merged

updating documentation #355
keighrim merged 19 commits into
developfrom
348-documentation

Conversation

@keighrim

Copy link
Copy Markdown
Member

addressing #348 and various minor documentation issues

CopilotAI review requested due to automatic review settings January 29, 2026 23:13
Comment threaddocumentation-notes.md Outdated
@keighrim
keighrim marked this pull request as draft January 29, 2026 23:15

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates project and CLI documentation to address issue #348 and improve Sphinx-generated docs, including summarizer and CLI module autodoc coverage.

Changes:

  • Refactors/standardizes docstrings across summarizer modules and CLI entry points.
  • Improves Sphinx docs structure (new summarizer page, new autodoc pages, updated index/modules, updated “what’s new” generation).
  • Adjusts CLI help text generation to be more readable in terminal help output and in published docs.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 12 comments.

Show a summary per file
FileDescription
mmif/utils/summarizer/utils.pyCleans up module docstring formatting.
mmif/utils/summarizer/summary.pyReplaces a very large module header with shorter module docs and refines class docstrings.
mmif/utils/summarizer/graph.pyImproves docstrings and type hints for Graph utilities and TokenIndex docs.
mmif/utils/summarizer/init.pyAdds a package-level docstring describing the summarizer behavior and usage.
mmif/utils/cli/summarize.pyAdds docstrings and typing for the summarize CLI module.
mmif/utils/cli/describe.pySimplifies CLI descriptions and adds an RST-oriented help generator.
mmif/init.pyAdds an argparse builder intended for documentation builds.
documentation/target-versions.rstRefines intro text for target-version docs.
documentation/summarizer.rstAdds a dedicated summarizer documentation page.
documentation/plugins.rstMinor wording/formatting cleanups in plugin docs.
documentation/modules.rstAdds autodoc entry for mmif.utils.cli.
documentation/introduction.rstUpdates installation/prerequisite text and improves examples.
documentation/index.rstReworks the Sphinx landing page structure and toctree.
documentation/conf.pyRefactors CLI/whatsnew generation during Sphinx builds; adds minor documentation-related utilities.
documentation/cli.rstUpdates CLI page wording and usage snippet.
documentation/autodoc/mmif.utils.summarizer.rstAdds autodoc page for the summarizer package/modules.
documentation/autodoc/mmif.utils.cli.rstAdds autodoc page for CLI package/modules.
documentation-notes.mdAdds internal notes about documentation work and open issues.
README.mdImproves README wording and links.
.gitignoreUpdates ignored generated docs artifact name (whatsnew.md).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threaddocumentation/plugins.rst Outdated
Comment threaddocumentation-notes.md Outdated
Comment threaddocumentation/conf.py Outdated
Comment threadmmif/utils/cli/describe.py Outdated
Comment threadmmif/utils/cli/describe.py Outdated
Comment threaddocumentation/introduction.rst Outdated
Comment threadREADME.md Outdated
Comment threadmmif/__init__.py Outdated
Comment threadmmif/utils/summarizer/graph.py
for video in mmif_obj.Mmif.get_documents_by_type(DocumentTypes.VideoDocument):
with open(video.location_path(), 'b') as in_video:
# do something with the video file
with open(video.location_path(), 'b') as in_video:

CopilotAIJan 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example uses file mode 'b' (binary) which is not a valid mode by itself in Python's open(). Use a concrete binary mode like 'rb' (read binary).

Suggested change
with open(video.location_path(), 'b') as in_video:
with open(video.location_path(), 'rb') as in_video:

Copilot uses AI. Check for mistakes.
@codecov

codecovBot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.58%. Comparing base (660d778) to head (5d36df6).
⚠️ Report is 23 commits behind head on develop.

Files with missing linesPatch %Lines
mmif/__init__.py83.33%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #355 +/- ##
===========================================
+ Coverage 65.62% 66.58% +0.96% 
===========================================
Files 22 22 Lines 2845 2846 +1 ===========================================
+ Hits 1867 1895 +28 + Misses 978 951 -27 
FlagCoverage Δ
unittests66.58% <93.75%> (+0.96%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keighrim

keighrim commented Jan 29, 2026

Copy link
Copy Markdown
MemberAuthor

@marcverhagen I did a force-push to your branch (really sorry about that, but the commit history was very messy (between cross-merges and PRs) and I couldn't read the code changes... Please pull fetch from your side and see if anything went bad during my cherry-picks and force push.

Comment threaddocumentation-notes.md Outdated
Comment threaddocumentation-notes.md Outdated
Comment threaddocumentation-notes.md Outdated
Comment threaddocumentation-notes.md Outdated
Comment threaddocumentation-notes.md Outdated

```
[!NOTE] mmif describe (and the underlying mmif.utils.workflow_helper) is still experimental and subject to change in future releases without notice. Backward compatibility is not guaranteed.
```

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you want to write a full parser/converter between md callout syntax and rst admonition syntax, I think we should just live with this. (also callouts in release notes aren't that frequent anyway)

Comment threaddocumentation/index.rst
Comment threaddocumentation/conf.py Outdated
Comment threadmmif/utils/cli/describe.py Outdated
Comment threaddocumentation/summarizer.rst
@keighrim

Copy link
Copy Markdown
MemberAuthor

I closed ("resolve" button) all the comments that are addressed in #356 .

@keighrim
keighrim marked this pull request as ready for review February 10, 2026 16:56
@keighrim

Copy link
Copy Markdown
MemberAuthor

Marc and I discussed changes in this PR (and #356 ) in a in-person meeting and decided to merge.

@keighrim
keighrim merged commit 503abe2 into developFeb 11, 2026
6 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in infraFeb 11, 2026
@keighrim
keighrim deleted the 348-documentation branch February 11, 2026 23:01
@keighrimkeighrim mentioned this pull request Mar 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@keighrim@clams-bot@marcverhagen