Skip to content

refactor: use sharded WAL - #1231

Open
BioPhoton wants to merge 66 commits into
mainfrom
feat/utils/sharded-profiling
Open

refactor: use sharded WAL#1231
BioPhoton wants to merge 66 commits into
mainfrom
feat/utils/sharded-profiling

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Precondition:

Related:

This PR incudes:

  • adjustments to make the node profiler generic in its output format (TraceEvent by default)
  • create factory for node profiler

@github-actionsgithub-actionsBot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils labels Jan 27, 2026
@nx-cloud

nx-cloudBot commented Jan 27, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 2f5edc9

CommandStatusDurationResult
nx run ci:code-pushup -- merge-diffs --files=/h...✅ Succeeded5sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded1m 30sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded13m 39sView ↗
nx run-many -t unit-test,int-test✅ Succeeded3sView ↗

☁️ Nx Cloud last updated this comment at 2026-03-29 16:17:22 UTC

@pkg-pr-new

pkg-pr-newBot commented Jan 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1231

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1231

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1231

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1231

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1231

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1231

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1231

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1231

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1231

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1231

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1231

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1231

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1231

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1231

commit: 5a7f6b5

# Conflicts:
#	packages/utils/docs/profiler.md
#	packages/utils/src/lib/profiler/constants.ts
#	packages/utils/src/lib/profiler/profiler.int.test.ts
#	packages/utils/src/lib/profiler/profiler.ts
#	packages/utils/src/lib/profiler/profiler.unit.test.ts

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/utils/src/lib/performance-observer.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.ts Outdated
Comment threadpackages/utils/src/lib/errors.ts Outdated
Comment threadpackages/utils/src/lib/performance-observer.ts Outdated
BioPhotonand others added 2 commits February 1, 2026 22:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

CopilotAI commented Feb 1, 2026

Copy link
Copy Markdown

@BioPhoton I've opened a new pull request, #1232, to work on those changes. Once the pull request is ready, I'll request review from you.

CopilotAI commented Feb 1, 2026

Copy link
Copy Markdown

@BioPhoton I've opened a new pull request, #1233, to work on those changes. Once the pull request is ready, I'll request review from you.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/utils/src/lib/wal.ts
Comment threadpackages/utils/src/lib/profiler/trace-file-utils.ts
Comment threadpackages/utils/src/lib/performance-observer.ts
@BioPhoton
BioPhoton removed the request for review from hanna-skrylFebruary 3, 2026 19:14
…ofiling
# Conflicts:
#	packages/utils/src/lib/process-id.ts
#	packages/utils/src/lib/process-id.unit.test.ts
#	packages/utils/src/lib/profiler/__snapshots__/comprehensive-stats-trace-events.jsonl
#	packages/utils/src/lib/profiler/__snapshots__/custom-tracks-trace-events.jsonl
#	packages/utils/src/lib/profiler/__snapshots__/sharded-path-trace-events.jsonl
#	packages/utils/src/lib/profiler/constants.ts
#	packages/utils/src/lib/profiler/profiler-node.int.test.ts
#	packages/utils/src/lib/profiler/profiler-node.ts
#	packages/utils/src/lib/profiler/trace-file-utils.ts
#	packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts
#	packages/utils/src/lib/profiler/trace-file.type.ts
#	packages/utils/src/lib/profiler/wal-json-trace.ts
#	packages/utils/src/lib/profiler/wal-json-trace.unit.test.ts
#	packages/utils/src/lib/wal.ts
#	packages/utils/src/lib/wal.unit.test.ts
…ofiling
# Conflicts:
#	packages/utils/src/lib/errors.ts
#	packages/utils/src/lib/wal-sharded.int.test.ts
#	packages/utils/src/lib/wal-sharded.ts
#	packages/utils/src/lib/wal-sharded.unit.test.ts
#	packages/utils/src/lib/wal.int.test.ts
#	packages/utils/src/lib/wal.ts
# Conflicts:
#	testing/test-utils/src/index.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton