refactor: simplify trace types and helper by BioPhoton · Pull Request #1236 · code-pushup/cli

BioPhoton · 2026-02-03T15:59:14Z

Implement performance profiling and trace file generation #1197

This PR includes:

simper tract event types
fixed detail structure
renamed helper
added unique id helper

Followup:

refactor: refactor sharded wal to handle coordinator #1237

nx-cloud · 2026-02-03T16:00:49Z

View your CI Pipeline Execution ↗ for commit 50a6580

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	5s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 32s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	13m 17s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-08 21:40:06 UTC

nx-cloud · 2026-02-03T16:00:49Z

View your CI Pipeline Execution ↗ for commit ad83c42

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	6s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 33s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	13m 39s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	1m 16s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-03 16:16:42 UTC

pkg-pr-new · 2026-02-03T16:01:03Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1236

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1236

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1236

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1236

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1236

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1236

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1236

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1236

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1236

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1236

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1236

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1236

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1236

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1236

commit: 50a6580

github-actions · 2026-02-03T16:10:05Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 11b52fe with previous commit 3137af7.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 40	🔴 35
Documentation	🟡 53	🟡 53
Code coverage	🟢 93	🟢 93
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Code style	🟢 100	🟢 100	–
Security	🔴 47	🔴 47	–
Updates	🟡 75	🟡 75	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👎 3 groups regressed, 👍 4 audits improved, 👎 8 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 40	🔴 35
JSDocs coverage	Documentation coverage	🟡 53	🟡 53
Code coverage	Code coverage metrics	🟢 93	🟢 93

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Initial server response time was short	🟥 Root document took 660 ms	🟩 Root document took 460 ms
Lighthouse	Total Blocking Time	🟥 1,040 ms	🟥 2,180 ms
Lighthouse	First Contentful Paint	🟥 3.3 s	🟥 3.0 s
JSDocs coverage	Types coverage	🟥 264 undocumented types	🟥 264 undocumented types
Lighthouse	Max Potential First Input Delay	🟥 620 ms	🟥 1,290 ms
JSDocs coverage	Variables coverage	🟥 274 undocumented variables	🟥 273 undocumented variables
Lighthouse	Time to Interactive	🟥 13.1 s	🟥 13.8 s
Lighthouse	Speed Index	🟥 6.8 s	🟥 6.8 s
JSDocs coverage	Functions coverage	🟥 585 undocumented functions	🟥 585 undocumented functions
JSDocs coverage	Properties coverage	🟥 42 undocumented properties	🟥 43 undocumented properties
Code coverage	Branch coverage	🟨 89.2 %	🟨 89.2 %
Code coverage	Line coverage	🟩 92.8 %	🟩 92.8 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,089 KiB	🟩 Total size was 2,097 KiB
Lighthouse	Minimizes main-thread work	🟥 8.1 s	🟥 12.2 s
Lighthouse	JavaScript execution time	🟥 2.1 s	🟥 3.7 s
Lighthouse	Server Backend Latencies	🟩 300 ms	🟩 1,070 ms
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Largest Contentful Paint	🟥 11.7 s	🟥 12.1 s
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 65 KiB	🟥 Potential savings of 80 KiB
Lighthouse	Network Round Trip Times	🟩 70 ms	🟩 0 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 111 KiB	🟥 Potential savings of 111 KiB
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 225 KiB	🟥 Potential savings of 225 KiB
TypeScript	Semantic errors	🟥 44 errors	🟥 37 errors
Lighthouse	Cumulative Layout Shift	🟩 0.003	🟩 0

654 other audits are unchanged.

github-actions · 2026-02-03T16:16:13Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 11b52fe with previous commit 3137af7.

💼 Project `utils`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🟡 61	🟡 60
Code coverage	🟢 95	🟢 95

4 other categories are unchanged.

👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🟡 61	🟡 60
Code coverage	Code coverage metrics	🟢 95	🟢 95

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Variables coverage	🟥 50 undocumented variables	🟥 49 undocumented variables
JSDocs coverage	Types coverage	🟨 55 undocumented types	🟨 55 undocumented types
JSDocs coverage	Functions coverage	🟥 243 undocumented functions	🟥 243 undocumented functions
JSDocs coverage	Properties coverage	🟥 39 undocumented properties	🟥 40 undocumented properties
Code coverage	Branch coverage	🟩 91.9 %	🟩 91.8 %
Code coverage	Line coverage	🟩 97.8 %	🟩 97.8 %

438 other audits are unchanged.

💼 Project `plugin-lighthouse`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟩 98.8 %	🟩 98.8 %

443 other audits are unchanged.

12 other projects are unchanged.

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

…ce-types

…ls/revamp-trace-types

hanna-skryl

Looks good! The type simplification, process-id.ts extraction, and the cleaned-up encode/decode flow are really nice improvements 👍

refactor: simplify trace types and helper
ad83c42

github-actionsBot assigned BioPhoton Feb 3, 2026

github-actionsBot added 🔬 testing writing tests 🧩 utils labels Feb 3, 2026

BioPhoton marked this pull request as ready for review February 3, 2026 16:18

refactor: wip
04ac4c3

BioPhoton requested a review from hanna-skryl February 3, 2026 18:22

This was referenced Feb 3, 2026
refactor: refactor sharded wal to handle coordinator #1237
Merged
Implement performance profiling and trace file generation #1197
Open

hanna-skryl reviewed Feb 3, 2026
View reviewed changes

BioPhotonand others added 9 commits February 3, 2026 21:48

Update packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts
36d74f8
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/process-id.unit.test.ts
7193a57
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/process-id.unit.test.ts
78d76d2
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts
c972833
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

refactor: remove redundant code
3f150db

refactor: fix incorrect instant event "ph" value
72e8baa

refactor: wip
5396322

refactor: wip
ef8f513

refactor: wip
058c9c1

BioPhoton requested a review from hanna-skryl February 3, 2026 21:47

BioPhoton enabled auto-merge (squash) February 3, 2026 22:11

hanna-skryl reviewed Feb 4, 2026
View reviewed changes

Comment threadpackages/utils/src/lib/profiler/trace-file-utils.ts
Comment threadpackages/utils/src/lib/wal.unit.test.ts Outdated
Comment threadpackages/utils/src/lib/process-id.unit.test.ts

BioPhoton added 3 commits February 8, 2026 12:42

refactor: remove duplicated tests
82d8c20

refactor: dedupe process-id tests
79f5c44

refactor: dedupe process-id tests
23087ed

BioPhoton added 3 commits February 8, 2026 12:48

refactor: adjust checks
10b8f3a

refactor: adjust metadata implementation
1adf937

refactor: adjust testing tsconfig to align wit the rest of the repo
8dec5a8

github-actionsBot added the 🛠️ tooling label Feb 8, 2026

BioPhoton added 6 commits February 8, 2026 13:33

Merge remote-tracking branch 'origin/main' into feat/utils/revamp-tra…
cf94d25
…ce-types

refactor: mock os
43b9540

Merge remote-tracking branch 'refs/remotes/origin/main' into feat/uti…
da0cb32
…ls/revamp-trace-types

refactor: wip
d761a3a

refactor: wip
f393a31

refactor: wip
50a6580

BioPhoton requested a review from hanna-skryl February 8, 2026 21:31

hanna-skryl approved these changes Feb 9, 2026
View reviewed changes

BioPhoton merged commit dd6e35e into mainFeb 9, 2026
24 checks passed

BioPhoton deleted the feat/utils/revamp-trace-types branch February 9, 2026 23:22

BioPhoton mentioned this pull request Feb 23, 2026
refactor: use sharded WAL #1231
Open

Uh oh!

Conversation

BioPhoton commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloudBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloudBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actionsBot commented Feb 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project utils

🗃️ Groups

🛡️ Audits

💼 Project plugin-lighthouse

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanna-skryl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BioPhoton commented Feb 3, 2026•
edited
Loading

nx-cloudBot commented Feb 3, 2026•
edited
Loading

nx-cloudBot commented Feb 3, 2026•
edited
Loading

pkg-pr-newBot commented Feb 3, 2026•
edited
Loading

github-actionsBot commented Feb 3, 2026•
edited
Loading

github-actionsBot commented Feb 3, 2026•
edited
Loading

💼 Project `utils`

💼 Project `plugin-lighthouse`