Skip to content

refactor: refactor sharded wal to handle coordinator - #1237

Merged
BioPhoton merged 29 commits into
mainfrom
feat/utils/handle-coordinator-in-sharded-wal
Feb 25, 2026
Merged

refactor: refactor sharded wal to handle coordinator#1237
BioPhoton merged 29 commits into
mainfrom
feat/utils/handle-coordinator-in-sharded-wal

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

Precondition:

Related:

This PR includes:

  • split sharded wal logic
  • handle coordinator in sharder

Followup:

@nx-cloud

nx-cloudBot commented Feb 3, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 00f4516

CommandStatusDurationResult
nx run ci:code-pushup -- merge-diffs --files=/h...✅ Succeeded5sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded1m 31sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded13m 7sView ↗
nx run-many -t unit-test,int-test✅ Succeeded12sView ↗

☁️ Nx Cloud last updated this comment at 2026-02-25 17:44:40 UTC

# Conflicts:
#	packages/utils/src/lib/wal.ts
#	packages/utils/src/lib/wal.unit.test.ts
…-sharded-wal' into feat/utils/handle-coordinator-in-sharded-wal
@pkg-pr-new

pkg-pr-newBot commented Feb 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1237

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1237

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1237

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1237

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1237

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1237

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1237

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1237

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1237

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1237

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1237

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1237

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1237

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1237

commit: 00f4516

@github-actions

github-actionsBot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit a5ef535 with previous commit 4c80af5.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Security🔴 0🔴 9↑ +9.3
Performance🔴 33🔴 36↑ +3.5
Best Practices🟢 97🟢 100↑ +3.4
Documentation🟡 53🟡 52↓ −1.3
Updates🟡 72🟡 73↑ +0.8
Code coverage🟢 93🟢 93↑ +0.1
Bug prevention🟡 75🟡 75↓ −0.1
Axe Accessibility🟡 88🟡 88↓ −0.1
Code style🟢 100🟢 100
Type Safety🟡 67🟡 67
Miscellaneous🟡 67🟡 67
Accessibility🟢 92🟢 92
SEO🟢 92🟢 92
👍 5 groups improved, 👎 1 group regressed, 👍 12 audits improved, 👎 5 audits regressed, 18 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
JS packagesnpm audit🔴 0🔴 9↑ +9.3
LighthousePerformance🔴 33🔴 36↑ +3.5
LighthouseBest Practices🟢 97🟢 100↑ +3.4
JSDocs coverageDocumentation coverage🟡 53🟡 52↓ −1.3
JS packagesnpm outdated dependencies🟡 72🟡 73↑ +0.8
Code coverageCode coverage metrics🟢 93🟢 93↑ +0.1

28 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseNo issues in the Issues panel in Chrome Devtools🟥 failed🟩 passed↑ +∞ %
LighthouseMax Potential First Input Delay🟥 1,650 ms🟥 440 ms↓ −73.5 %
LighthouseSpeed Index🟥 7.0 s🟥 6.1 s↓ −13.3 %
JS packagesVulnerabilities for npm prod dependencies.🟥 22 vulnerabilities (13 high, 3 moderate, 6 low)🟥 16 vulnerabilities (6 high, 3 moderate, 7 low)↓ −27.3 %
LighthouseTotal Blocking Time🟥 2,750 ms🟥 1,850 ms↓ −32.8 %
LighthouseTime to Interactive🟥 14.4 s🟥 12.7 s↓ −11.8 %
JSDocs coverageClasses coverage🟨 5 undocumented classes🟨 6 undocumented classes↑ +20 %
LighthouseFirst Contentful Paint🟥 3.4 s🟥 3.2 s↓ −4.4 %
JSDocs coverageProperties coverage🟥 43 undocumented properties🟥 48 undocumented properties↑ +11.6 %
JSDocs coverageMethods coverage🟨 10 undocumented methods🟨 14 undocumented methods↑ +40 %
JS packagesOutdated npm prod dependencies.🟨 21 outdated package versions (7 major, 11 minor, 3 patch)🟨 22 outdated package versions (7 major, 12 minor, 3 patch)↑ +4.8 %
JSDocs coverageTypes coverage🟥 264 undocumented types🟥 278 undocumented types↑ +5.3 %
JSDocs coverageVariables coverage🟥 273 undocumented variables🟥 274 undocumented variables↑ +0.4 %
Code coverageFunction coverage🟩 94.4 %🟩 94.6 %↑ +0.2 %
Code coverageLine coverage🟩 92.7 %🟩 92.8 %↑ +0.1 %
JSDocs coverageFunctions coverage🟥 585 undocumented functions🟥 595 undocumented functions↑ +1.7 %
Code coverageBranch coverage🟨 89.2 %🟨 89.1 %↓ −0.1 %
LighthouseMinimizes main-thread work🟥 13.9 s🟥 10.3 s↓ −25.4 %
LighthouseJavaScript execution time🟥 5.5 s🟥 3.3 s↓ −39.2 %
LighthouseLargest Contentful Paint🟥 11.6 s🟥 9.6 s↓ −17.4 %
LighthouseMetrics🟩 100%🟩 100%↓ −11.8 %
LighthouseUses efficient cache policy on static assets🟨 31 resources found🟨 31 resources found↑ +0.1 %
LighthouseAvoids enormous network payloads🟩 Total size was 2,136 KiB🟩 Total size was 2,136 KiB↓ −0.1 %
LighthouseReduce unused JavaScript🟥 Potential savings of 255 KiB🟥 Potential savings of 255 KiB↓ −25.4 %
LighthouseReduce unused CSS🟥 Potential savings of 110 KiB🟥 Potential savings of 79 KiB↓ −25.4 %
LighthouseServer Backend Latencies🟩 1,280 ms🟩 1,380 ms↑ +7.8 %
LighthouseInitial server response time was short🟩 Root document took 500 ms🟩 Root document took 580 ms↑ +15.6 %
JS packagesVulnerabilities for npm dev dependencies.🟥 81 vulnerabilities (3 critical, 65 high, 10 moderate, 3 low)🟥 51 vulnerabilities (3 critical, 33 high, 11 moderate, 4 low)↓ −37 %
LighthouseAvoids an excessive DOM size🟥 2,360 elements🟥 2,368 elements↑ +0.3 %
AxeElements must only use supported ARIA attributes🟩 96 elements🟩 98 elements↑ +2.1 %
AxeARIA attributes must be used as specified for the element's role🟩 96 elements🟩 98 elements↑ +2.1 %
AxeElements must only use permitted ARIA attributes🟩 96 elements🟩 98 elements↑ +2.1 %
AxeARIA attributes must conform to valid names🟩 96 elements🟩 98 elements↑ +2.1 %
AxeARIA hidden element must not be focusable or contain focusable elements🟩 202 elements🟩 203 elements↑ +0.5 %
LighthouseNetwork Round Trip Times🟩 60 ms🟩 60 ms↓ −1.2 %

643 other audits are unchanged.

@BioPhoton
BioPhoton marked this pull request as ready for review February 23, 2026 08:53
@github-actions

github-actionsBot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit a5ef535 with previous commit 4c80af5.

💼 Project create-cli

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Documentation🟡 64🔴 22↓ −42.1
Code coverage🟢 96🟢 98↑ +2.4

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 3 audits regressed

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
JSDocs coverageDocumentation coverage🟡 64🔴 22↓ −42.1
Code coverageCode coverage metrics🟢 96🟢 98↑ +2.4

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
JSDocs coverageMethods coverage🟩 0 undocumented methods🟥 4 undocumented methods↑ +∞ %
JSDocs coverageClasses coverage🟩 0 undocumented classes🟥 1 undocumented classes↑ +∞ %
JSDocs coverageProperties coverage🟩 0 undocumented properties🟥 1 undocumented properties↑ +∞ %
JSDocs coverageFunctions coverage🟥 6 undocumented functions🟥 17 undocumented functions↑ +183.3 %
Code coverageBranch coverage🟨 87.5 %🟩 94.8 %↑ +8.4 %
JSDocs coverageTypes coverage🟥 1 undocumented types🟥 14 undocumented types↑ +1300 %
Code coverageLine coverage🟩 97 %🟩 98.9 %↑ +2 %

436 other audits are unchanged.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Documentation🟡 60🟡 61↑ +0.6
Code coverage🟢 95🟢 95↓ −0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 3 audits regressed

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
JSDocs coverageDocumentation coverage🟡 60🟡 61↑ +0.6
Code coverageCode coverage metrics🟢 95🟢 95↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
JSDocs coverageMethods coverage🟨 10 undocumented methods🟨 10 undocumented methods +0 %
JSDocs coverageProperties coverage🟥 40 undocumented properties🟥 44 undocumented properties↑ +10 %
Code coverageBranch coverage🟩 91.8 %🟩 91.2 %↓ −0.6 %
JSDocs coverageTypes coverage🟨 55 undocumented types🟨 56 undocumented types↑ +1.8 %
JSDocs coverageVariables coverage🟥 49 undocumented variables🟥 50 undocumented variables↑ +2 %
Code coverageFunction coverage🟩 95.8 %🟩 95.9 %↑ +0.1 %
JSDocs coverageFunctions coverage🟥 243 undocumented functions🟥 242 undocumented functions↓ −0.4 %
Code coverageLine coverage🟩 97.8 %🟩 97.8 %↑ +0.1 %

436 other audits are unchanged.


12 other projects are unchanged.

Comment threadpackages/utils/src/lib/wal.int.test.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.unit.test.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.int.test.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.ts Outdated
Comment threadpackages/utils/src/lib/wal.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.int.test.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.ts
Comment threadpackages/utils/src/lib/wal-sharded.ts Outdated
BioPhotonand others added 12 commits February 23, 2026 16:16
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Comment threadpackages/utils/src/lib/wal.unit.test.ts Outdated
Comment threadpackages/utils/src/lib/wal-sharded.ts Outdated
Comment threadpackages/utils/src/lib/errors.ts Outdated
BioPhotonand others added 2 commits February 25, 2026 15:58
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
@BioPhoton
BioPhoton enabled auto-merge (squash) February 25, 2026 15:23
@BioPhoton
BioPhoton merged commit 226ceb9 into mainFeb 25, 2026
24 checks passed
@BioPhoton
BioPhoton deleted the feat/utils/handle-coordinator-in-sharded-wal branch February 25, 2026 17:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton@hanna-skryl