4.5.6 Ready code - #9345

Merged
paulbalandan merged 155 commits into
masterfrom
develop
Dec 28, 2024
Merged

4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom
develop

Conversation

@paulbalandan

@paulbalandanpaulbalandan commented Dec 28, 2024

Copy link
Copy Markdown
Member

No description provided.

kenjisand others added 30 commits September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others added 24 commits December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan

paulbalandan commented Dec 28, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.

Fixed in #9346

This was referenced Dec 28, 2024
Merged
Merged
@paulbalandan
paulbalandan merged commit 51cdd7d into masterDec 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
4.5.6 Ready code - #9345
Merged
paulbalandan merged 155 commits into
masterfrom 
develop
Dec 28, 2024
Merged
4.5.6 Ready code#9345
paulbalandan merged 155 commits into
masterfrom 
develop
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Dec 28, 2024

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 6, 2024 13:53
@kenjis
docs: fix param types
3dfd4bc
@kenjis
docs: decorate text
2ef57ab
@kenjis
docs: add changelog and upgrade for v4.5.6
b5b2e57
@kenjis
docs: add note
ee9ae5f
@kenjis
docs: move item
2492078
@kenjis
docs: move section
cb4ba98
@kenjis
docs: use GitHub markdown note format
d7bedff
@kenjis
Merge pull request#9175from kenjis/docs-changelog-4.5.6
ce7f591
docs: add changelog and upgrade for v4.5.6
@kenjis
Merge pull request#9171from kenjis/docs-url_helper.rst
268156c
docs: improve url_helper.rst
@kenjis
Merge pull request#9176from kenjis/update-RELEASE.md
0a6b39d
docs: update RELEASE.md
@kenjis
docs: improve description for Migration File Names
22cf15e
@kenjis
docs: add link to section
7113792
@kenjis
docs: fix typo
e53c32c
@kenjis
fix: auto_link() converts invalid string like "://codeigniter.com"
791fe2f
The scheme is missing, so it is not a valid URL.
@kenjis
refactor: break long lines
94fe31f
@kenjis
Merge pull request#9179from kenjis/improve-migration-file-names
647f4e7
docs: improve "Migration File Names"
@dependabot
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
3776790
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@1.2.4...1.2.5)
---
updated-dependencies:
- dependency-name: rector/rector
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
@samsonasik
Fix phpstan
0a9835b
@samsonasik
Merge pull request#9183from codeigniter4/dependabot/composer/rector…
b678930
…/rector-1.2.5
chore(deps-dev): update rector/rector requirement from 1.2.4 to 1.2.5
@samsonasik
refactor: enable TypedPropertyFromAssignsRector
45a002f
@ddevsr
docs: broken link htmx ajax-header
fe65154
@samsonasik
Merge pull request#9184from samsonasik/refactor-typed-property
092d85b
refactor: enable TypedPropertyFromAssignsRector
@samsonasik
refactor: enable ClosureReturnTypeRector
3f29f28
@samsonasik
Fix cs
8ecbf0d
@samsonasik
Merge pull request#9187from samsonasik/refactor-enable-closure-return
1528d3d
refactor: enable ClosureReturnTypeRector
@kenjis
Merge pull request#9185from ddevsr/broken-link-htmx-ajax
36f9c2f
docs: broken link htmx ajax-header
@kenjis
docs: fix Project Files changes
7d2d81c
See https://forum.codeigniter.com/showthread.php?tid=91656&pid=421265#pid421265
@kenjis
Merge pull request#9180from kenjis/fix-auto_link-bug
d49d700
fix: auto_link() converts invalid strings like `://codeigniter.com`
@kenjis
chore: update psr/log to 3.0.2
d6850d4
@kenjis
Merge pull request#9188from kenjis/fix-upgrade_455.rst
bd3ee0f
docs: fix Project Files changes in upgrade_455.rst
samsonasikand others
added 24 commits
December 11, 2024 23:48
@samsonasik
Merge pull request#9315from paulbalandan/method-namecase
f5200b5
refactor: fix `method.nameCase` errors
@samsonasik
Merge pull request#9314from paulbalandan/rename-controller-to-Contr…
0b0126c
…oller
refactor: rename `controller` to `Controller`
@paulbalandan
refactor: fix implicit array creation
c06d928
@samsonasik
Merge pull request#9316from paulbalandan/implicit-array-creation
e9bb603
refactor: fix implicit array creation
@michalsn@datamweb
fix: check if definedWRITEPATHexists (#9317)
9bc61b3
* fix: check if defined WRITEPATH exists
* cs fix
* Update system/Boot.php
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
* cs fix
---------
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@ddevsr
refactor: followup style variable array (#9319)
0f5de27
@samsonasik
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicen…
94e57df
…seRule
@samsonasik
chore: fix ci run
6644b79
@samsonasik
Merge pull request#9321from samsonasik/chore-prepare-phpstan-2
f0536a1
chore: preparation for PHPStan 2: remove CheckUseStatementsAfterLicenseRule
@paulbalandan
refactor: split phpstan-baseline into smaller files (#9299)
242745c
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
@samsonasik
refactor: upgrade to use phpstan 2 and rector 2 (#9322)
61881bd
@andifahruddinakas
docs: phpdoc incorrect explanation regarding variable naming (#9326)
17f7a9d
* Update FileHandler.php
* Update BaseConnection.php
* Update Connection.php
* Update filesystem_helper.php
* Update Security.php
* Update SecurityInterface.php
@andifahruddinakas
docs: variable naming adjustments (#9324)
cc2dcee
* Update 006.php
* Update 008.php
* Update 046.php
@paulbalandan
refactor: fixForge::processIndexes()for empty$this->fields(#9330
f48aa6f
)
@neznaika0
fix: Remove DB files after tests (#9192)
ab5536f
@paulbalandan
refactor:Reflection*::setAccessible()is now no-op in PHP 8.1 (#9331)
8fa419f
@paulbalandan
refactor: add @throws RedirectException in Controller::initControll…
cc1b8f2
…er (#9327)
@michalsn
fix: handling binary data for prepared statement (#9337)
6cbbf60
* fix prepare statement sqlite
* fix prepare statement postgre
* fix prepare statement sqlsrv
* fix prepare statement oci8
* tests
* abstract isBinary() method
* fix prepare statement mysqli
* fix prepare statement oci8
* sqlsrv blob support
* fix tests
* add changelog
* fix rector
* make sqlsrv happy
* make oci8 happy - hopefully
* add a note about options for prepared statement
* ignore PreparedQueryTest.php file
* apply code suggestion for oci8
@paulbalandan
refactor: fix warning on new static usage
2114577
@samsonasik
Merge pull request#9342from paulbalandan/new-static
e363f47
refactor: fix warning on new static usage
@paulbalandan
refactor: fix used void return type (#9341)
19ad2b9
@neznaika0
refactor: fixphpstanonly boolean allowed (#9302)
8cff099
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
@samsonasik
refactor: enable instanceof and strictBooleans rector set (#9339)
ee4ee98
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
@paulbalandan
Prep for 4.5.6 release (#9344)
6785d8f
@paulbalandan
paulbalandan
commented
Dec 28, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think the failures are because composer cannot find the tag ^4.5 for codeigniter4/framework within this repo. In other PRs where base branch is develop, composer correctly maps develop as 4.x-dev. However, since base branch is master, I think composer no longer has the knowledge.
Fixed in #9346

This was referenced Dec 28, 2024
 Merged

 Merged

@paulbalandan
paulbalandan
merged commit 51cdd7d
into
masterDec 28, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

17 participants

@paulbalandan@samsonasik@cesperanc@kenjis@ddevsr@datamweb@element-code@michalsn@grimpirate@CosDiabos@maniaba@neznaika0@ping-yee@JulianAtkins@obozdag@TechnoKaa@andifahruddinakas