fix(Win32): scale window sizes and Material Symbol boxes by the window's DPI - #8
Open
vitalyster wants to merge 3 commits into
Open
fix(Win32): scale window sizes and Material Symbol boxes by the window's DPI#8vitalyster wants to merge 3 commits into
vitalyster wants to merge 3 commits into
Conversation
The glyph font is scaled by the monitor DPI (pointSize × dpiScale) but the STATIC box holding it was not, so icons were cropped on high-DPI displays. Scale the box too. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 20, 2026
SwiftUI window sizes are logical points; windows were created at the same number of physical pixels, so a 1100×720 window appeared as 550×360 at 200% DPI. Sizes the app specifies (defaultWindowSize, windowSizing(.size), min/max track sizes) are now scaled by the window's own DPI (per-monitor). Windows without a specified size keep the CW_USEDEFAULT system default instead of the previous hardcoded 400×300/500×600 fallbacks.
Text rendered at DPI-scaled font sizes while the boxes around it were measured at 96 DPI, so at 200% DPI buttons came out half-size and cropped. - measureText scales the default 14pt by the window's DPI (DirectWrite format and GDI fallback) - the D2D flat button paints with the scaled default size - the D2D render target pins its DPI to 96 so drawing coordinates match the layout engine's physical pixels (the default system-DPI target reinterpreted every coordinate as DIPs and doubled sizes at 200%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Win32 DPI fixes (three commits):
Material Symbol glyph boxes scale with DPI. The glyph font is scaled by the monitor DPI but the STATIC box holding it was not, so icons were cropped on high-DPI displays.
Window sizes are scaled by the window's own DPI. SwiftUI window sizes (defaultWindowSize, windowSizing(.size), min/max track sizes) are logical points; the backend created windows at the same number of physical pixels, so a 1100×720 window appeared as 550×360 at 200% DPI. Specified sizes are now scaled by
GetDpiForWindow(per-monitor). Windows without a specified size keep theCW_USEDEFAULTsystem default instead of the previous hardcoded 400×300/500×600 fallbacks.Text measurement and D2D rendering scale with DPI. Text rendered at DPI-scaled font sizes while the boxes around it were measured at 96 DPI, so at 200% DPI buttons came out half-size and cropped.
measureTextnow scales by the window's DPI; the D2D flat button paints with the scaled default size; the D2D render target pins its DPI to 96 so drawing coordinates match the layout engine's physical pixels.Expected doc impact: parity matrix / implementation tracker may want a DPI-awareness note (coordinator-owned).