Uh oh!
There was an error while loading. Please reload this page.
Use OS aware runner instead of bash for run-local command; fixed loading requirements.txt on Windows - #2996
Merged
Merged
Conversation
andrewnester
requested review from
anton-107, denik, pietern and shreyas-goenka
as code ownersJune 5, 2025 14:45
andrewnestertemporarily deployed
to
test-trigger-is
June 5, 2025 14:45 — with 
GitHub Actions
Inactive
pietern
reviewed
Jun 5, 2025
| return err | ||
| } | ||
| _, err = e.Exec(p.ctx, strings.Join(args, " ")) | ||
| return err |
Contributor
There was a problem hiding this comment.
This no longer forwards stdout/stderr.
ContributorAuthor
There was a problem hiding this comment.
Yes, addressed it here f6c8211
Wanted to tests which PR tests are actually failing on missing output
andrewnestertemporarily deployed
to
test-trigger-is
June 5, 2025 15:33 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
June 5, 2025 15:40 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 09:02 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 09:22 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 09:50 — with GitHub Actions
Inactive
shreyas-goenka
approved these changes
Jun 6, 2025
denik
reviewed
Jun 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 11:03 — with GitHub Actions
Inactive
andrewnester
enabled auto-merge
June 6, 2025 11:03
pietern
reviewed
Jun 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Jun 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 11:35 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 11:39 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
June 6, 2025 11:40 — with GitHub Actions
Inactive
andrewnester
enabled auto-merge
June 6, 2025 11:40
pietern
reviewed
Jun 6, 2025
| if e.inheritOutput { | ||
| cmd.Stdout = os.Stdout | ||
| cmd.Stderr = os.Stderr | ||
| cmd.Stdin = os.Stdin |
Contributor
There was a problem hiding this comment.
Inherit output should not inherit the input.
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jun 11, 2025
## Release v0.255.0 ### Notable Changes * Fix `databricks auth login` to tolerate URLs copied from the browser ([#3001](#3001)). ### CLI * Use OS aware runner instead of bash for run-local command ([#2996](#2996)) ### Bundles * Fix "bundle summary -o json" to render null values properly ([#2990](#2990)) * Fix dashboard generation for already imported dashboard ([#3016](#3016)) * Fixed null pointer de-reference if artifacts missing fields ([#3022](#3022)) * Update bundle templates to also include `resources/*/*.yml` ([#3024](#3024)) * Apply YAML formatter on default-python and dbt-sql templates ([#3026](#3026))
denik pushed a commit
that referenced
this pull request
May 20, 2026
…ing requirements.txt on Windows (#2996) ## Changes Use OS aware runner instead of bash for run-local command ## Why `bash` might be not available on Windows and this also makes it consistent with other command executors like artifact building ## Tests Existing acceptance tests pass <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.255.0 ### Notable Changes * Fix `databricks auth login` to tolerate URLs copied from the browser ([#3001](#3001)). ### CLI * Use OS aware runner instead of bash for run-local command ([#2996](#2996)) ### Bundles * Fix "bundle summary -o json" to render null values properly ([#2990](#2990)) * Fix dashboard generation for already imported dashboard ([#3016](#3016)) * Fixed null pointer de-reference if artifacts missing fields ([#3022](#3022)) * Update bundle templates to also include `resources/*/*.yml` ([#3024](#3024)) * Apply YAML formatter on default-python and dbt-sql templates ([#3026](#3026))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use OS aware runner instead of bash for run-local command
Why
bashmight be not available on Windows and this also makes it consistent with other command executors like artifact buildingTests
Existing acceptance tests pass