Uh oh!
There was an error while loading. Please reload this page.
Enable yaml formatter; fix formatting in default-python & dbt-sql - #3026
Merged
Conversation
denik
requested review from
alexott, andrewnester, anton-107, nfx, pietern and shreyas-goenka
as code ownersJune 10, 2025 14:37
| autoscale: | ||
| min_workers: 1 | ||
| max_workers: 4 | ||
| min_workers: 1 |
Contributor
There was a problem hiding this comment.
Are .yml.tmpl files automatically formatted?
ContributorAuthor
There was a problem hiding this comment.
No, this is done manually.
| tools/yamlfmt: go.mod | ||
| go build -o tools/yamlfmt github.com/google/yamlfmt/cmd/yamlfmt | ||
| yamlfmt: tools/yamlfmt |
Contributor
There was a problem hiding this comment.
Make this a part of the normal make fmt rule rather than a separate one?
| ruff format -n | ||
| ./tools/lintdiff.py fmt | ||
| # pre-building yamlfmt because I also want to call it from tests |
Contributor
There was a problem hiding this comment.
Which test do you call it from?
denik added a commit
that referenced
this pull request
Jun 11, 2025
shreyas-goenka
approved these changes
Jun 11, 2025
denik
disabled auto-merge
June 11, 2025 13:42
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jun 11, 2025
## Release v0.255.0 ### Notable Changes * Fix `databricks auth login` to tolerate URLs copied from the browser ([#3001](#3001)). ### CLI * Use OS aware runner instead of bash for run-local command ([#2996](#2996)) ### Bundles * Fix "bundle summary -o json" to render null values properly ([#2990](#2990)) * Fix dashboard generation for already imported dashboard ([#3016](#3016)) * Fixed null pointer de-reference if artifacts missing fields ([#3022](#3022)) * Update bundle templates to also include `resources/*/*.yml` ([#3024](#3024)) * Apply YAML formatter on default-python and dbt-sql templates ([#3026](#3026))
denik added a commit
that referenced
this pull request
Jun 13, 2025
pietern
reviewed
Jun 16, 2025
| # build: <second_option_command> | ||
| # build: <first_option_command> | ||
| # path: <path> | ||
| # build: <second_option_command> |
Contributor
There was a problem hiding this comment.
This is different from what I expected; when I uncomment these lines, they are incorrectly indented.
ContributorAuthor
There was a problem hiding this comment.
Yeah, it does not do well on comments. I had to disable formatting of this one altogether (but forgot to undo changes) because it's not stable: google/yamlfmt#253
denik added a commit
that referenced
this pull request
May 20, 2026
denik added a commit
that referenced
this pull request
May 20, 2026
) ## Changes - Update 'make fmt' to format yaml with https://github.com/google/yamlfmt/ - Templates dbt-sql and default-python updated to have consistent indentation according to formatter. ## Why For templates with a lot of options (default-python) it's easy to introduce formatting issues - too many empty lines or not enough in the output. I'd like to use formatter also on non-materialized templates in default-python/combinations to ensure that resulting yamls are formatted well for any possible combination of options. Related: #3004
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.255.0 ### Notable Changes * Fix `databricks auth login` to tolerate URLs copied from the browser ([#3001](#3001)). ### CLI * Use OS aware runner instead of bash for run-local command ([#2996](#2996)) ### Bundles * Fix "bundle summary -o json" to render null values properly ([#2990](#2990)) * Fix dashboard generation for already imported dashboard ([#3016](#3016)) * Fixed null pointer de-reference if artifacts missing fields ([#3022](#3022)) * Update bundle templates to also include `resources/*/*.yml` ([#3024](#3024)) * Apply YAML formatter on default-python and dbt-sql templates ([#3026](#3026))
denik added a commit
that referenced
this pull request
May 20, 2026
denik pushed a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
For templates with a lot of options (default-python) it's easy to introduce formatting issues - too many empty lines or not enough in the output. I'd like to use formatter also on non-materialized templates in default-python/combinations to ensure that resulting yamls are formatted well for any possible combination of options. Related: #3004