Uh oh!
There was an error while loading. Please reload this page.
Switch default-python to use pyproject.toml & uv & dynamic_version in dev [uv_build variant] - #3004
Closed
denik wants to merge 1 commit into
Closed
Switch default-python to use pyproject.toml & uv & dynamic_version in dev [uv_build variant]#3004denik wants to merge 1 commit into
denik wants to merge 1 commit into
Conversation
denik
changed the base branch from
yaml_formatter
to
denik/acc-yamlfmt-default-python-combinationsJune 11, 2025 10:21
denikforce-pushed
the
denik/acc-yamlfmt-default-python-combinations
branch
from
June 11, 2025 11:22
96c21f3 to
555ff71Comparedenik added a commit
that referenced
this pull request
Jun 11, 2025
) ## Changes - Update 'make fmt' to format yaml with https://github.com/google/yamlfmt/ - Templates dbt-sql and default-python updated to have consistent indentation according to formatter. ## Why For templates with a lot of options (default-python) it's easy to introduce formatting issues - too many empty lines or not enough in the output. I'd like to use formatter also on non-materialized templates in default-python/combinations to ensure that resulting yamls are formatted well for any possible combination of options. Related: #3004
denikforce-pushed
the
denik/acc-yamlfmt-default-python-combinations
branch
2 times, most recently
from
June 12, 2025 09:41
4819b26 to
2797a28Comparegithub-merge-queueBot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…#3032) ## Changes - Add yamlcheck.py to acceptance tests that uses yamlfmt to check YAML formatting. - Modify default-python/combinations to run yamlcheck.py on every instance of the template. - Clean up trailing whitespace in default-python found by this test. - Add $TESTROOT env var to acceptance tests (needed to find the config). ## Why Preparing for more changes in default-python #3004
Base automatically changed from
denik/acc-yamlfmt-default-python-combinations to
mainJune 12, 2025 10:46
denik
commented
Jun 12, 2025
ContributorAuthor
Switched to hatchling backend here #3042 |
denik added a commit
that referenced
this pull request
Jul 2, 2025
… dev [hatchling backend] (#3042) ## Changes - Update default-python template to use pyproject.toml and uv (with hatchling). - Get rid of dynamic version in setup.py and using dynamic_version attribute on artifacts instead (only in dev target and only on non-serverless clusters since serverless has fixed the issue with versions not being updated in the platform). See #2427#2520 ## Why Modern Python is based around pyproject.toml, not setup.py. Using DAB-provided dynamic_version attribute allows keeping pyproject.toml simple and does not constraint what build backend users can choose. Note, I've also considered using uv_build backend #3004 but it seems too early at the moment and hatchling is better tested with DABs. ## Tests Existing tests.
denik added a commit
that referenced
this pull request
May 20, 2026
) ## Changes - Update 'make fmt' to format yaml with https://github.com/google/yamlfmt/ - Templates dbt-sql and default-python updated to have consistent indentation according to formatter. ## Why For templates with a lot of options (default-python) it's easy to introduce formatting issues - too many empty lines or not enough in the output. I'd like to use formatter also on non-materialized templates in default-python/combinations to ensure that resulting yamls are formatted well for any possible combination of options. Related: #3004
denik added a commit
that referenced
this pull request
May 20, 2026
…#3032) ## Changes - Add yamlcheck.py to acceptance tests that uses yamlfmt to check YAML formatting. - Modify default-python/combinations to run yamlcheck.py on every instance of the template. - Clean up trailing whitespace in default-python found by this test. - Add $TESTROOT env var to acceptance tests (needed to find the config). ## Why Preparing for more changes in default-python #3004
denik added a commit
that referenced
this pull request
May 20, 2026
… dev [hatchling backend] (#3042) ## Changes - Update default-python template to use pyproject.toml and uv (with hatchling). - Get rid of dynamic version in setup.py and using dynamic_version attribute on artifacts instead (only in dev target and only on non-serverless clusters since serverless has fixed the issue with versions not being updated in the platform). See #2427#2520 ## Why Modern Python is based around pyproject.toml, not setup.py. Using DAB-provided dynamic_version attribute allows keeping pyproject.toml simple and does not constraint what build backend users can choose. Note, I've also considered using uv_build backend #3004 but it seems too early at the moment and hatchling is better tested with DABs. ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3042