Skip to content

Remove trailing whitespace in default-python; enforce yaml formatting - #3032

Merged
denik merged 9 commits into
mainfrom
denik/acc-yamlfmt-default-python-combinations
Jun 12, 2025
Merged

Remove trailing whitespace in default-python; enforce yaml formatting#3032
denik merged 9 commits into
mainfrom
denik/acc-yamlfmt-default-python-combinations

Conversation

@denik

@denikdenik commented Jun 11, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Add yamlcheck.py to acceptance tests that uses yamlfmt to check YAML formatting.
  • Modify default-python/combinations to run yamlcheck.py on every instance of the template.
  • Clean up trailing whitespace in default-python found by this test.
  • Add $TESTROOT env var to acceptance tests (needed to find the config).

Why

Preparing for more changes in default-python #3004

@denik
deniktemporarily deployed to test-trigger-is June 11, 2025 10:12 — with GitHub Actions Inactive
@denik
deniktemporarily deployed to test-trigger-is June 11, 2025 10:33 — with GitHub Actions Inactive
@denikdenik mentioned this pull request Jun 11, 2025
Merged
@denik
denikforce-pushed the denik/acc-yamlfmt-default-python-combinations branch from 4cb23cf to 96c21f3CompareJune 11, 2025 10:38
@denik
deniktemporarily deployed to test-trigger-is June 11, 2025 10:38 — with GitHub Actions Inactive
@denikdenik mentioned this pull request Jun 11, 2025
Merged
denik added a commit that referenced this pull request Jun 11, 2025
@denik
acc: include tools in PATH (#3030)
c9184a8
## Changes
Made ./tools/ available for acceptance tests.
## Why
Some tools are useful both in project and in tests, for example yamlfmt
(#3026) is useful to check
templates without materializing them
(#3032).
@denik
denik requested review from alexott and nfx as code ownersJune 11, 2025 11:21
@denik
denikforce-pushed the denik/acc-yamlfmt-default-python-combinations branch from 96c21f3 to 555ff71CompareJune 11, 2025 11:22
@denik
deniktemporarily deployed to test-trigger-is June 11, 2025 11:22 — with GitHub Actions Inactive
Base automatically changed from yaml_formatter to mainJune 11, 2025 13:42
@denik
denikforce-pushed the denik/acc-yamlfmt-default-python-combinations branch from 555ff71 to c4d5fb2CompareJune 11, 2025 13:43
@denik
deniktemporarily deployed to test-trigger-is June 11, 2025 13:43 — with GitHub Actions Inactive
@denikdenik changed the title Remove trailing whitespace in default-python; enforce yaml formatting for all instancesRemove trailing whitespace in default-python; enforce yaml formattingJun 11, 2025
@denik
deniktemporarily deployed to test-trigger-is June 12, 2025 08:31 — with GitHub Actions Inactive
@denik
denikforce-pushed the denik/acc-yamlfmt-default-python-combinations branch from 152fa10 to ffdf65bCompareJune 12, 2025 09:00
@denik
deniktemporarily deployed to test-trigger-is June 12, 2025 09:01 — with GitHub Actions Inactive
@denik
deniktemporarily deployed to test-trigger-is June 12, 2025 09:25 — with GitHub Actions Inactive
@denik
denikforce-pushed the denik/acc-yamlfmt-default-python-combinations branch from 4819b26 to 2797a28CompareJune 12, 2025 09:41
@denik
deniktemporarily deployed to test-trigger-is June 12, 2025 09:41 — with GitHub Actions Inactive
@denik
deniktemporarily deployed to test-trigger-is June 12, 2025 09:50 — with GitHub Actions Inactive
@denik
denik enabled auto-merge June 12, 2025 10:02
@denik
denik added this pull request to the merge queueJun 12, 2025
Merged via the queue into main with commit b5c872eJun 12, 2025
@denik
denik deleted the denik/acc-yamlfmt-default-python-combinations branch June 12, 2025 10:46
denik added a commit that referenced this pull request May 20, 2026
@denik
acc: include tools in PATH (#3030)
afba086
## Changes
Made ./tools/ available for acceptance tests.
## Why
Some tools are useful both in project and in tests, for example yamlfmt
(#3026) is useful to check
templates without materializing them
(#3032).
denik added a commit that referenced this pull request May 20, 2026
@denik
Remove trailing whitespace in default-python; enforce yaml formatting (…
39588c1
…#3032)
## Changes
- Add yamlcheck.py to acceptance tests that uses yamlfmt to check YAML
formatting.
- Modify default-python/combinations to run yamlcheck.py on every
instance of the template.
- Clean up trailing whitespace in default-python found by this test.
- Add $TESTROOT env var to acceptance tests (needed to find the config).
## Why
Preparing for more changes in default-python
#3004
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyas-goenkashreyas-goenkashreyas-goenka approved these changes
@pieternpieternAwaiting requested review from pietern
@andrewnesterandrewnesterAwaiting requested review from andrewnester
@anton-107anton-107Awaiting requested review from anton-107
@alexottalexottAwaiting requested review from alexott
@nfxnfxAwaiting requested review from nfx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denik@shreyas-goenka