Uh oh!
There was an error while loading. Please reload this page.
direct: add declarative config, remove FieldTriggers() - #4304
Merged
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Implement yaml.Marshaler and yaml.Unmarshaler interfaces for PathNode, enabling direct use in YAML configs with automatic parsing and validation. Tests cover: - Marshal/unmarshal of various path patterns - Error handling for invalid syntax - Roundtrip consistency - Usage in struct fields with []*PathNode - Null and empty string edge cases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This removes the programmatic FieldTriggers() methods from all resources and replaces them with a declarative YAML configuration file (dresources/resources.yml) that is embedded into the binary. Changes: - Add ResourceLifecycleConfig struct with RecreateOnChanges, UpdateIDOnChanges, IgnoreRemoteChanges fields using *structpath.PathNode - Add resources.yml with all existing FieldTriggers data migrated - Update Adapter to accept resourceType and load config from YAML - Update bundle_plan.go to use config directly via getActionFromConfig() - Remove FieldTriggers() from IResource interface and all resource types - Replace ReasonFieldTriggers with ReasonResourceConfig - Update tests to validate against ResourceConfig 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 16, 2026 15:26
Update ResourceLifecycleConfig.IgnoreLocalChanges to be a list of field patterns instead of a boolean. Add models.tags to both ignore_remote_changes and ignore_local_changes since tags cannot be updated via the normal API. Also reorder resources.yml sections to match Resources struct order and move comments closer to the fields they describe. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Since resources.yml is embedded at compile time, parsing errors indicate a bug in the code rather than a runtime condition. Use panic instead of returning an error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Commit: bba0a1e
24 interesting tests: 12 RECOVERED, 6 KNOWN, 3 FAIL, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jan 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jan 19, 2026
Collaborator
Commit: d2dab23
30 interesting tests: 10 KNOWN, 8 RECOVERED, 6 flaky, 5 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik added a commit
that referenced
this pull request
Jan 29, 2026
## Changes - Fix ignore_remote_changes to ignoring only remote changes (it was ignoring all on a given path). - Respect ignore_local_changes setting. Currently, few resources use it (experiments, database_catalogs, synced_database_tables since #4364). Follow up to #4304 ## Tests Existing. I have follow up PRs that make more use of ignore_remote_changes which make this bug apparent.
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Add resources.yml which is declarative part of resource configuration. - Remove FieldTriggers(), no longer needed. - Add custom YAML marshallers to PathNode so that it can be used in config structs. ## Why Makes the behaviour more visible and easier to tweak. It also matches names and format that we can add later to databricks.yml, e.g. lifecycle.ignore_remote_changes. Potentially, we can also allow overriding the whole config at runtime, so you can tweak / test different behaviour without rebuilding CLI. ## Tests Existing tests. --------- Co-authored-by: Claude <noreply@anthropic.com>
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Fix ignore_remote_changes to ignoring only remote changes (it was ignoring all on a given path). - Respect ignore_local_changes setting. Currently, few resources use it (experiments, database_catalogs, synced_database_tables since #4364). Follow up to #4304 ## Tests Existing. I have follow up PRs that make more use of ignore_remote_changes which make this bug apparent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Makes the behaviour more visible and easier to tweak. It also matches names and format that we can add later to databricks.yml, e.g. lifecycle.ignore_remote_changes.
Potentially, we can also allow overriding the whole config at runtime, so you can tweak / test different behaviour without rebuilding CLI.
Tests
Existing tests.