Uh oh!
There was an error while loading. Please reload this page.
acc: invariant: support init/cleanup scripts; fix synced_database_table - #4364
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 23, 2026 13:45
pietern
approved these changes
Jan 23, 2026
denik
enabled auto-merge
January 23, 2026 14:28
andrewnester
approved these changes
Jan 23, 2026
Collaborator
Commit: 0a00fe9
31 interesting tests: 13 flaky, 8 RECOVERED, 5 KNOWN, 5 SKIP
Top 50 slowest tests (at least 2 minutes):
|
eng-dev-ecosystem-bot
commented
Jan 23, 2026
Collaborator
Commit: 3a5bdc8
27 interesting tests: 10 flaky, 7 RECOVERED, 5 KNOWN, 5 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik added a commit
that referenced
this pull request
Jan 29, 2026
## Changes - Fix ignore_remote_changes to ignoring only remote changes (it was ignoring all on a given path). - Respect ignore_local_changes setting. Currently, few resources use it (experiments, database_catalogs, synced_database_tables since #4364). Follow up to #4304 ## Tests Existing. I have follow up PRs that make more use of ignore_remote_changes which make this bug apparent.
denik added a commit
that referenced
this pull request
May 20, 2026
…le (#4364) ## Changes - Extend invariant tests to allow custom init/cleanup scripts. - Use that to create unique source table to avoid "20 tables" limit on cloud. Same fix as #4329 - Ignore_remote_changes for synced_database_tables fields: database_instance_name and database_instance_name (not set by the backend, cause drift). - Ignore_remote_changes for database_catalog.create_database_if_not_exists (not set by the backend, cause drift). ## Why Fixes invariant/no_drift test for synced_database_tables and database_catalogs.
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Fix ignore_remote_changes to ignoring only remote changes (it was ignoring all on a given path). - Respect ignore_local_changes setting. Currently, few resources use it (experiments, database_catalogs, synced_database_tables since #4364). Follow up to #4304 ## Tests Existing. I have follow up PRs that make more use of ignore_remote_changes which make this bug apparent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Fixes invariant/no_drift test for synced_database_tables and database_catalogs.