Implement Sum and Product traits for fixed point numbers - #47
Closed
richardhozak wants to merge 1 commit into
Closed
Implement Sum and Product traits for fixed point numbers#47richardhozak wants to merge 1 commit into
richardhozak wants to merge 1 commit into
Conversation
This makes it so simd_horizontal_sum and simd_horizontal_product can be implemented for fixed point numbers.
|
Hello, I understand that this PR can be closed, as it has been developed more in #48 ? |
Author
|
Yes, the linked PR contains these changes. This is just subset, so it could be reviewed more easily. If it is desirable, this can be closed in favor of #48. |
|
I am not maintainer obviously, but its already in review for few months with no response. you can see exact same commit in the second PR, so its nicely splitted and you can clearly see this subset there. So I would close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so simd_horizontal_sum and simd_horizontal_product can be implemented for fixed point numbers.
f32 and f64 have these traits implemented in std, we need to implement them manually so fixed point numbers can be used instead floating point numbers