Implement most of missing functionality for fixed point - #48
Closed
richardhozak wants to merge 3 commits into
Closed
Implement most of missing functionality for fixed point#48richardhozak wants to merge 3 commits into
richardhozak wants to merge 3 commits into
Conversation
This makes it so simd_horizontal_sum and simd_horizontal_product can be implemented for fixed point numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements missing functionality for fixed point numbers that is needed for parry to use fixed point numbers as reals instead of f32 or f64.
Some of the functionality is generalized and some of it is implemented only for FixedI32F32 fixed point number, as that is what I used to test this with parry.
I would like to get this completed for all fixed point numbers, so parry or other crates can use arbitrary fixed point numbers, but I am not sure how to continue (there is some
Fromconversions in fixed_point.rs that I know how to generalize, but I am not sure how toimpl_float_simd!for all fixed point numbers).Could anyone point me in correct direction in order for me to complete this?