Uh oh!
There was an error while loading. Please reload this page.
Add --template-driver option for secrets/configs - #896
Conversation
| return types.ConfigCreateResponse{}, errors.Errorf("expected name %q, got %q", name, spec.Name) | ||
| } | ||
| if !reflect.DeepEqual(spec.Templating.Name, expectedDriver.Name) { |
There was a problem hiding this comment.
isn't this just a comparing a string? so it could use != ?
There was a problem hiding this comment.
hm, yes, copy-pasta'd from TestSecretCreateWithDriver. Let me update
18798e8 to
57abb70CompareCodecov Report
@@ Coverage Diff @@## master #896 +/- ##
==========================================
+ Coverage 53.23% 53.25% +0.02%
==========================================
Files 258 258 Lines 16347 16357 +10 ==========================================
+ Hits 8702 8711 +9 - Misses 7081 7082 +1
Partials 564 564 |
thaJeztah
commented
Feb 21, 2018
Thinking if |
| assert.Equal(t, "ID-"+name, strings.TrimSpace(cli.OutBuffer().String())) | ||
| } | ||
| func TestConfigCreateWithTemplatingDriver(t *testing.T) { |
There was a problem hiding this comment.
Test for config create without driver?
There was a problem hiding this comment.
There's a test above that doesn't have a driver, is that what you meant?
There was a problem hiding this comment.
We should check and make sure Templating is nil in that case, I think?
There was a problem hiding this comment.
This would be done already if the test used DeepEqual on the entire spec instead of looking at specific fields. Maybe we should do that here as well.
dnephin
commented
Feb 21, 2018
I like |
57abb70 to
c4b596bComparethaJeztah
commented
Feb 21, 2018
Changed to |
thaJeztah
commented
Feb 21, 2018
hmf, secrets side is failing; But I don't see a different: |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
e34df9f to
d11b5ccCompare
relates to moby/moby#33702