Update release branch - #3333

Merged
shauheen merged 73 commits into
dotnet:release/1.0from
shauheen:RC2
Apr 14, 2019
Merged

Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from
shauheen:RC2

Conversation

@shauheen

@shauheenshauheen commented Apr 13, 2019

Copy link
Copy Markdown
Contributor

This PR updates the 1.0 release branch with changes from Master branch.

shauheenand others added 30 commits March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others added 9 commits April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs

codemzs commented Apr 13, 2019

Copy link
Copy Markdown
Member

Awesome!

eerhardt
eerhardt approved these changes Apr 13, 2019
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.

TomFinley
TomFinley approved these changes Apr 13, 2019
View reviewed changes

@TomFinleyTomFinley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.

@shauheen
shauheen merged commit 3b964cc into dotnet:release/1.0Apr 14, 2019
This was referenced Apr 14, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@shauheen
shauheen deleted the RC2 branch April 15, 2019 23:01
@ghostghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@glebukglebukAwaiting requested review from glebuk
2 more reviewers
@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Update release branch - #3333
Merged
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Apr 14, 2019
Merged
Update release branch#3333
shauheen merged 73 commits into
dotnet:release/1.0from 
shauheen:RC2
Conversation
@shauheen
@shauheenshauheen
commented
Apr 13, 2019

Copy link


Copy Markdown

Contributor
This PR updates the 1.0 release branch with changes from Master branch.
shauheenand others
added 30 commits
March 26, 2019 11:06
@shauheen
Bump master to 1.1 and 0.13 (dotnet#3091)
3663320
@zeahmed
Binary LR samples using T4 templates (dotnet#3099)
70c6418
@zeahmed
Created samples for 'FeaturizeText' API. (dotnet#3120)
233bc2d
@zeahmed
Created sample for 'TokenizeIntoCharactersAsKeys' API. (dotnet#3123)
ee5fbe0
@codemzs
Fix grammar in exception message. (dotnet#3122)
617f0f6
@MarcinJuraszek@Ivanidzo4ka
Pass weighting value from ProduceWordBags to WordBagEstimator constru…
e95f31d
…ctor (dotnet#3135)
@abgoswam
Fix missing ExampleWeightColumnName in the advanced Options for some …
0a2ec3a
…trainers (dotnet#3104)
* fixed issue, added tests
* fix review comments
* updating equality checks for floats
@zeahmed
Created sample for 'ApplyWordEmbedding' API. (dotnet#3142)
21b5bb4
@zeahmed
Created sample for text normalizing API. (dotnet#3133)
f93e973
@TomFinley
Update VBuffer documentation (dotnet#3136)
e5cbca7
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
@Ivanidzo4ka
Restore OVA ability to preserve key names on predicted label (dotnet#…
d2bf3e7
…3101)
@zeahmed
Updating .tt file due to renaming of LbfgsPoissonRegression. (dotnet#…
41a6308
…3140)
@codemzs
Move Normalizer extension method from experimental to stable nuget an…
fde1ab7
…d remove Normalizer generic APIs (dotnet#3118)
* Move Normalizer extension method from experimental to stable nuget.
* Cleanup unused method in Normalizer Estimator.
* remove normalizer estimator catalog methods that take enum as parameter.
* Remove Microsoft.ML.Experimental references in CS files.
* merge fix.
* cleanup.
* cleanup.
* PR feedback.
@shauheen@eerhardt
Disable push to myget (dotnet#3157)
0ce5618
@shauheen
Adding release notes for RC1 (dotnet#3176)
51fc8b2
* Adding release notes for RC1
@zeahmed
Created samples for TokenizeIntoWords and RemoveStopWords APIs. (dot…
950f133
…net#3156)
@eerhardt@shauheen
Fix NuGet badge on README to show pre-release (dotnet#3189)
1412ce1
@eerhardt
Fix IncludeBuildNumberInPackageVersion for official builds (dotnet#3182)
9a80b78
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.
Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
@codemzs
Multi-column mapping API for normalizer estimators. (dotnet#3172)
a7bcdda
* Multi-column mapping for Normalizer estimators.
* XML comment.
* revert Program.cs
* Add copyright header.
* Add tests.
* PR feedback.
* cleanup.
* PR feedback.
@abgoswam
Samples and unit test for image-related transform estimators (dotnet#…
ac53748
…3165)
* updating image samples
* fix review comments (print preview)
* fix comments (minor nits)
* fix review comments (whitespaces)
@sfilipi
Conversion catalog samples (dotnet#3167)
e285889
* adding a sample for convert MultiColumns. Moving files around.
* Adjust the samples about ValueMapping
* Addressing PR comments
@TomFinley
Key type documentation. (dotnet#3194)
dfa38ab
* Key type documentation.
@shauheen
Update Readme
e54f295
@zeahmed
Created samples for 'ProduceWordBags' and 'ProduceHashedWordBags' API. (
24645ff
dotnet#3183)
@abgoswam
Samples for categorical transform estimators (dotnet#3179)
9d79ab3
* categorical transform estimators
* review comments
* fix review comments
* modify samples namespace
@wschin
Fix a value-mapping bug (dotnet#3180)
b8a70ac
@zeahmed
Created sample for 'LatentDirichletAllocation' API. (dotnet#3191)
a8915f4
@zeahmed
Created samples for 'ProduceNgrams' and 'ProduceHashedNgrams' APIs. (d…
854f154
…otnet#3177)
@abgoswam
Samples for FeatureSelection transform estimators (dotnet#3184)
8130567
* samples for FeatureSelection transform estimators
* fix review comments
* fix review comments
* review comments
* take care of review comments
* fix copy paste output error
@codemzs
TimeSeriesStatics naming. (dotnet#3215)
b291d95
wschinand others
added 9 commits
April 11, 2019 15:03
@wschin@codemzs
Try buid LIBMF with OpenMP again (dotnet#3297)
a602476
* Try buiid omp again
* Add LIBMF's fix
@codemzs
Fix runtime exception in Prior trainer sample and update the sample o…
41ba426
…utput in comments. (dotnet#3295)
@wschin
Add a sample for one class matrix factorization (dotnet#3282)
89a1fb9
@codemzs
Fix runtime exception in MapKeyToVectorMultiColumn.cs. (dotnet#3305)
663e939
@TomFinley
Fix ofdotnet#3822to address some inadvertently omitted fixes on Vec…
43d4c18
…torDataViewType documentation. (dotnet#3296)
@TomFinley
Simple IDataView implementation sample. (dotnet#3302)
326727f
@Ivanidzo4ka
Put product version with git commit into model.zip/version.txt (dotne…
37ed336
…t#3173)
@rogancarr
Extend Gam Samples (dotnet#3281)
e37e5b1
* Adding Regression and Binary Classification GAM samples.
Shauheen Zahirazami
Merge branch 'master' into RC2
2dfcb57
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
codemzs
commented
Apr 13, 2019

Copy link


Copy Markdown

Member
Awesome!
eerhardt
eerhardt
approved these changes
Apr 13, 2019
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.
TomFinley
TomFinley
approved these changes
Apr 13, 2019
View reviewed changes
@TomFinleyTomFinley
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.
@shauheen
shauheen
merged commit 3b964cc
into
dotnet:release/1.0Apr 14, 2019

This was referenced Apr 14, 2019
 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

 Closed

@shauheen
shauheen
deleted the

RC2

branch
April 15, 2019 23:01
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 22, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@glebukglebukAwaiting requested review from glebuk

2 more reviewers

@eerhardteerhardteerhardt approved these changes
@TomFinleyTomFinleyTomFinley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

15 participants

@shauheen@codemzs@eerhardt@TomFinley@karuzzo@zeahmed@MarcinJuraszek@abgoswam@Ivanidzo4ka@sfilipi@wschin@rogancarr@ganik@artidoro@tauheedul