Skip to content

[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702

Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0

Description

@lambdageek
lambdageek
opened on Oct 6, 2022

Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)

Repro:

  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)

Expected result:

The hot reload change is applied and the application keeps running.

Actual result:

dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.

In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:

Mac:

Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:

Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue

runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061 in 8571fcb

if (pField->IsStatic())
p = pField->GetCurrentStaticAddress();
else {
p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object);
}
GCPROTECT_END();
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) {
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable());

This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.

By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.

Metadata

Metadata

Assignees

Labels

area-Diagnostics-coreclr

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR · Issue #76702 · dotnet/runtime · GitHub
Skip to content
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702
Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0
Description
@lambdageek
lambdageek
opened on Oct 6, 2022
Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)
Repro:
  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)
Expected result:
The hot reload change is applied and the application keeps running.
Actual result:
dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.
In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:
Mac:
Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:
Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue
runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061
in
8571fcb
if (pField->IsStatic()) 
 p = pField->GetCurrentStaticAddress(); 
else { 
 p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); 
 } 
GCPROTECT_END(); 
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) { 
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable()); 
This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.
By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.
Metadata
Metadata
Assignees
Labels
area-Diagnostics-coreclr
Type
No type
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR · Issue #76702 · dotnet/runtime · GitHub
Skip to content
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702
Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0
Description
@lambdageek
lambdageek
opened on Oct 6, 2022
Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)
Repro:
  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)
Expected result:
The hot reload change is applied and the application keeps running.
Actual result:
dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.
In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:
Mac:
Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:
Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue
runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061
in
8571fcb
if (pField->IsStatic()) 
 p = pField->GetCurrentStaticAddress(); 
else { 
 p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); 
 } 
GCPROTECT_END(); 
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) { 
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable()); 
This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.
By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.
Metadata
Metadata
Assignees
Labels
area-Diagnostics-coreclr
Type
No type
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR · Issue #76702 · dotnet/runtime · GitHub
Skip to content
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702
Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0
Description
@lambdageek
lambdageek
opened on Oct 6, 2022
Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)
Repro:
  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)
Expected result:
The hot reload change is applied and the application keeps running.
Actual result:
dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.
In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:
Mac:
Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:
Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue
runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061
in
8571fcb
if (pField->IsStatic()) 
 p = pField->GetCurrentStaticAddress(); 
else { 
 p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); 
 } 
GCPROTECT_END(); 
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) { 
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable()); 
This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.
By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.
Metadata
Metadata
Assignees
Labels
area-Diagnostics-coreclr
Type
No type
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR · Issue #76702 · dotnet/runtime · GitHub
Skip to content
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702
Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0
Description
@lambdageek
lambdageek
opened on Oct 6, 2022
Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)
Repro:
  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)
Expected result:
The hot reload change is applied and the application keeps running.
Actual result:
dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.
In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:
Mac:
Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:
Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue
runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061
in
8571fcb
if (pField->IsStatic()) 
 p = pField->GetCurrentStaticAddress(); 
else { 
 p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); 
 } 
GCPROTECT_END(); 
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) { 
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable()); 
This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.
By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.
Metadata
Metadata
Assignees
Labels
area-Diagnostics-coreclr
Type
No type
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR · Issue #76702 · dotnet/runtime · GitHub
Skip to content
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702
Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0
Description
@lambdageek
lambdageek
opened on Oct 6, 2022
Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)
Repro:
  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)
Expected result:
The hot reload change is applied and the application keeps running.
Actual result:
dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.
In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:
Mac:
Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:
Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue
runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061
in
8571fcb
if (pField->IsStatic()) 
 p = pField->GetCurrentStaticAddress(); 
else { 
 p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); 
 } 
GCPROTECT_END(); 
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) { 
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable()); 
This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.
By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.
Metadata
Metadata
Assignees
Labels
area-Diagnostics-coreclr
Type
No type
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR · Issue #76702 · dotnet/runtime · GitHub
Skip to content
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR #76702
Closed
#90446
Closed
[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR#76702
#90446
Assignees
mikelle-rogers
Labels
area-Diagnostics-coreclr
Milestone
9.0.0
Description
@lambdageek
lambdageek
opened on Oct 6, 2022
Found this while working on #76462, but it also reproduces with net7 (and probably net6.0 and older, see below)
Repro:
  1. dotnet new console
  2. Use the following for Program.cs:
// #define UPDATEusingSystem.Reflection;publicclassTest{publicstaticvoidMain(){boolstop=false;Console.CancelKeyPress+=new((sender,ev)=>{ev.Cancel=true;stop=true;});varc0=newC();inti=0;while(!stop){Body(refi);}Console.WriteLine("stopping");GC.KeepAlive(c0);}staticvoidBody(refinti){Console.WriteLine($"alive {i}");i+=1;Thread.Sleep(1000);
#if UPDATEvarc=newC();varfi=c.GetType().GetField("MyS");vars=fi.GetValue(c);// bad!Console.WriteLine("still alive");
#endif
}classC{
#if UPDATEpublicSMyS;
#endif
publicC(){
#if UPDATEMyS=newS{D=-1985.0,O=newint[2]{15,17},};
#endif
}
#if UPDATEpublicstructS{publicdoubleD;publicobjectO;};
#endif
}}
  1. Run dotnet watch (but I believe this would also reproduce with EnC in Visual Studio)
  2. Change // #define UPDATE to #define UPDATE and save (or hit "Apply Changes" in VS)
Expected result:
The hot reload change is applied and the application keeps running.
Actual result:
dotnet watch 🚀 Started
alive 0
alive 1
alive 2
alive 3
alive 4
alive 5
alive 6
dotnet watch ⌚ File changed: ./Program.cs.
alive 7
dotnet watch 🔥 Hot reload of changes succeeded.
alive 8
dotnet watch ❌ Exited with error code 139
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet watch 🛑 Shutdown requested. Press Ctrl+C again to force exit.

That is, the child process - dotnet running the user code crashed with exit code 139.
In #76462 we actually get a good combination of error messages from a CoreCLR builds on OSX and Windows, respectively:
Mac:
Assert failure(PID 21236 [0x000052f4], Thread: 191148 [0x2eaac]): IS_ALIGNED(src, sizeof(SIZE_T))
File: /Users/runner/work/1/s/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 736
Image: /private/tmp/helix/working/B02E09C7/p/dotnet

Windows:
Fatal error. Internal CLR error. (0x80131506)
at System.RuntimeFieldHandle.GetValue(System.Reflection.RtFieldInfo, System.Object, System.RuntimeType, System.RuntimeType, Boolean ByRef)
at System.Reflection.RtFieldInfo.GetValue(System.Object)
at System.Reflection.Metadata.ApplyUpdateTest+<>c.<TestAddInstanceField>b__10_0()
at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean)
at System.Reflection.MethodInvoker.InterpretedInvoke(System.Object, IntPtr*)
at System.Reflection.MethodInvoker.Invoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.MethodInvoker.InlinedInvoke(System.Object, IntPtr*, System.Reflection.BindingFlags)
at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Microsoft.DotNet.RemoteExecutor.Program.Main(System.String[])

Which points to InvokeUtil::GetFieldValue
runtime/src/coreclr/vm/invokeutil.cpp

Lines 1051 to 1061
in
8571fcb
if (pField->IsStatic()) 
 p = pField->GetCurrentStaticAddress(); 
else { 
 p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); 
 } 
GCPROTECT_END(); 
// copy the field to the unboxed object.
// note: this will be done only for the non-remoting case
if (p) { 
CopyValueClass(obj->GetData(), p, fieldType.AsMethodTable()); 
This looks wrong - p = (*((BYTE**)target)) + pField->GetOffset() + sizeof(Object); for fields added by EnC - they aren't at some offset, they're allocated entirely separately from the target object.
By the way, the same wrong logic is also in InvokeUtil::SetValidField so probably RtFieldInfo.SetField/RuntimeFieldHandle.SetField has issues too.
Metadata
Metadata
Assignees
Labels
area-Diagnostics-coreclr
Type
No type
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests
Issue actions