Tests ran counter by VincentBu · Pull Request #111145 · dotnet/runtime

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu · 2025-01-07T09:25:26Z

Record how many times each test ran for. (even if the run is terminated manually)

dotnet-policy-service · 2025-01-07T09:26:13Z

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

markples · 2025-01-07T18:35:04Z

 using System.Linq;

 using System.Runtime.Loader;
+using Microsoft.CodeAnalysis.CSharp.Syntax;


I don't think this is needed

markples · 2025-01-07T18:40:47Z

+ public void RecordTestRanCount()
+ {
+ StringBuilder sb = new();
+ foreach(var item in _testRanCounter)


When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.

markples · 2025-01-07T18:56:56Z

+ if (!_testRanCounter.Keys.Contains(testRefOrID))
+ {
+ _testRanCounter[testRefOrID] = 0;
+ }
+ _testRanCounter[testRefOrID] ++;


(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)

mrsharm · 2025-01-08T09:37:47Z

+ sb.AppendLine($"{item.Key}: {item.Value}");
+ } 
+ }
+ _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}");


NIT: Tests run* count.

mrsharm · 2025-01-08T09:39:23Z

 ReliabilityFramework rf = new ReliabilityFramework();
 rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started");
+
+ Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => {


NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }

mrsharm · 2025-01-08T09:39:51Z

 return (retVal);
 }

+ public void RecordTestRanCount()


NIT: The name RecordTestRunCount seems more apt.

mrsharm

LGTM!

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

VincentBu added 2 commits January 7, 2025 15:56

record how many times each test ran for
7539bc5

record all tests
fcd48c2

ghost added the area-GC-coreclr label Jan 7, 2025

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025

VincentBu requested review from cshung and mrsharm January 7, 2025 09:25

markples reviewed Jan 7, 2025
View reviewed changes

use lock when constructing string and clean the code
aec9629

mrsharm reviewed Jan 8, 2025
View reviewed changes

VincentBu added 2 commits January 9, 2025 14:37

rename counter
4c63543

remove sln file
18bbc15

mrsharm approved these changes Jan 9, 2025
View reviewed changes

build-analysisBot mentioned this pull request Jan 9, 2025
ModuleNotFoundError: No module named 'pkg_resources' dotnet/dnceng#4756
Closed
3 tasks

Merge branch 'main' into TestRanCounter
77ef42a

mrsharm merged commit b2a6266 into dotnet:mainFeb 3, 2025

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

VincentBu deleted the TestRanCounter branch July 29, 2025 06:50

Uh oh!

Conversation

VincentBu commented Jan 7, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrsharm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

VincentBu commented Jan 7, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrsharm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

VincentBu commented Jan 7, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrsharm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers