Change how we build the cross-OS DAC to support building in the VMR by jkoritzinsky · Pull Request #111927 · dotnet/runtime

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky · 2025-01-28T18:49:09Z

Don't build the cross-os DACs as part of the default subsets. Breaks in them are very rare nowadays and we do have CI protection for them
Look up the runtimes for the cross-os DAC packages by pulling them out of the runtime packs, not using a different special artifact name.
Build the cross-os DACs and pack them all in one subset. This makes enabling building these components easier in the VMR.

Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).

Contributes to dotnet/source-build#4631

…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

…sing a separate artifact

Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script

dotnet-policy-service · 2025-01-28T18:49:39Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

… cross-dac invocation from the join jobs.

…n Subsets.props

jkoritzinsky · 2025-02-03T21:10:35Z

Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

jkoritzinsky added 4 commits January 17, 2025 14:19

Don't build the linuxdac by default. Cross-os DAC build failures are …
afa727c
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.

Rewrite cross-os DAC packaging in terms of runtime packs instead of u…
2f515e7
…sing a separate artifact

Build the cross-os DACs when crossdacpack is built.
89dd90b

jkoritzinsky added the area-Infrastructure-coreclr Only use for closed issues label Jan 28, 2025

jkoritzinsky requested a review from hoyosjs January 28, 2025 18:49

dotnet-policy-serviceBot assigned jkoritzinsky Jan 28, 2025

jkoritzinsky added 2 commits January 28, 2025 11:25

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto xos-dac
bef55a0

Forward the ESRP tool path down from DotNetBuild.props and set up the…
b71364c
… cross-dac invocation from the join jobs.

jkoritzinsky requested a review from ViktorHofer January 28, 2025 21:19

ViktorHofer reviewed Jan 28, 2025
View reviewed changes

Comment threadeng/extract-for-crossdac.ps1

Pass down the buildpass to the inner build and decide what to build i…
cad52e8
…n Subsets.props

jkoritzinsky mentioned this pull request Jan 28, 2025
Sign the DAC and build (and sign) the cross-OS DACs in the VMR dotnet/sdk#46377
Merged

Allow passing a script root (needed for VMR reusage of this template)
484ed2a

This was referenced Jan 29, 2025
Build on Windows Fails sometimes with fatal error C1090: PDB API call failed #48070
Open
[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090
Closed

jkoritzinsky added 2 commits February 3, 2025 11:38

Adjust DAC signing script to fix failures in internal testing
d5b2151

Force the value of SignRequestFiles to always be an array
accde76

hoyosjs reviewed Feb 3, 2025
View reviewed changes

Build the cross-os DACs via their subset names
852fc69

hoyosjs approved these changes Feb 4, 2025
View reviewed changes

hoyosjs merged commit dea928c into dotnet:mainFeb 4, 2025

jkoritzinsky deleted the xos-dac branch February 4, 2025 08:13

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

Uh oh!

Conversation

jkoritzinsky commented Jan 28, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jkoritzinsky commented Jan 28, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jkoritzinsky commented Jan 28, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jkoritzinsky commented Jan 28, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 28, 2025

jkoritzinsky commented Feb 3, 2025•
edited
Loading

jkoritzinsky commented Feb 3, 2025•
edited
Loading

jkoritzinsky commented Feb 3, 2025•
edited
Loading

jkoritzinsky commented Feb 3, 2025•
edited
Loading

jkoritzinsky commented Feb 3, 2025•
edited
Loading