JIT: Fix cross crossgen comparison failures by AndyAyersMS · Pull Request #112078 · dotnet/runtime

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS · 2025-02-03T00:53:05Z

Fix a couple of issues that were causing cross-crossgen tests to fail

address mode formation was sensitive to the size of a constant handle
value histogram processing was always using 64 bit value sizes
transformation for down-counted loops was using host-sized -1.

Fixes the jit-related issues in #111972

dotnet-policy-service · 2025-02-03T00:53:39Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-02-03T00:53:53Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T00:54:04Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS · 2025-02-03T15:27:23Z

cross crossgen results

Looks like xarch is now ok. OSX arm64 has a type layout verification failure. So maybe the jit side of things is in good shape.

20:20:39.940 Running test: JIT/opt/Devirtualization/Comparer_get_Default/Comparer_get_Default.dll
Assert failure(PID 13022 [0x000032de], Thread: 4596379 [0x46229b]): Verify_TypeLayout 'DoubleEnum' failed to verify type layout
File: /Users/runner/work/1/s/src/coreclr/vm/jitinterface.cpp:13800
Image: /private/tmp/helix/working/97380862/p/corerun

AndyAyersMS · 2025-02-03T15:39:34Z

@dotnet/jit-contrib PTAL

EgorBo · 2025-02-03T15:44:10Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

jakobbotsch · 2025-02-03T16:23:40Z

 else
 {
- *result = m_comp->gtNewIconNode((ssize_t)cns->Value, scev->Type);
+ *result = m_comp->gtNewIconNode((target_ssize_t)cns->Value, scev->Type);


Can you make ScevConstant's constructor apply the sign extension for the genTypeSize(type) == 4 case instead? It better matches how GenTreeIntCon works (the constant is always stored sign extended).

Not sure I did what you expected, so take a look. My local setup got messed up so it will be a while before I can tell if this works.

That looks good to me

AndyAyersMS · 2025-02-03T16:25:19Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?

Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

jkotas · 2025-02-03T16:27:58Z

Verify_TypeLayout 'DoubleEnum' failed to verify type layout

Known issues: https://github.com/dotnet/runtime/issues?q=is%3Aissue%20state%3Aopen%20%22Verify_TypeLayout%20%27DoubleEnum%27%20failed%20to%20verify%20type%20layout%22

AndyAyersMS · 2025-02-03T18:02:07Z

Previous commit's diffs have regressions, is it because of the addressing modes or PGO-related changes?
Ah, I hadn't looked at those. Would guess it is the PGO change, but let me verify.

Spot checked some diffs, and yeah, looks like histogram computations were off before (always using host pointer sized bits to tabulate the histogram, then projecting to the low 32 bits). Typically value histograms on x64 were more "washed out" than they should have been).

It was likely hard to spot this during testing as it required histograms with mixtures of sizes and a good idea what the actual final %s should have looked like (eg the old interpretation is approximately correct, especially when the % of the dominant entry is high).

So the general sharpening in histogram % usually leads us to do some unrolling and so increase sizes (on x64 anyways).

Note the only x86 diffs are in the crossgen collection; when jitting it was reading the histograms properly.

EgorBo · 2025-02-03T18:48:50Z

ah, so some regressions are actually more value-probe driven intrinsic expanded? That explains some diffs I've looked into

AndyAyersMS · 2025-02-03T20:08:41Z

/azp run runtime-coreclr crossgen2 outerloop

azure-pipelines · 2025-02-03T20:08:54Z

Azure Pipelines successfully started running 1 pipeline(s).

* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

AndyAyersMS added 3 commits February 1, 2025 09:41

fix address mode formation
fe61e7b

fix value histogram processing
51be2d2

fix down counted loops
c67ec1d

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 3, 2025

dotnet-policy-serviceBot assigned AndyAyersMS Feb 3, 2025

This was referenced Feb 3, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

AndyAyersMS changed the title ~~Fix111972~~Fix111972 -- Cross crossgen comparison failuresFeb 3, 2025

AndyAyersMS marked this pull request as ready for review February 3, 2025 15:29

format
38bf2ec

AndyAyersMS changed the title ~~Fix111972 -- Cross crossgen comparison failures~~JIT: Fix cross crossgen comparison failuresFeb 3, 2025

jakobbotsch reviewed Feb 3, 2025
View reviewed changes

EgorBo approved these changes Feb 3, 2025
View reviewed changes

revise scev change
e40dde7

jakobbotsch approved these changes Feb 3, 2025
View reviewed changes

AndyAyersMS merged commit 6f7c6fb into dotnet:mainFeb 3, 2025

AndyAyersMS mentioned this pull request Feb 3, 2025
Crossgen2 comparisons are failing in coreclr-outerloop runs #111972
Closed

AndyAyersMS mentioned this pull request Feb 11, 2025
[Perf] Linux/x64: 1 Improvement on 2/4/2025 12:21:12 AM +00:00 dotnet/perf-autofiling-issues#49903
Closed

github-actionsBot locked and limited conversation to collaborators Mar 6, 2025

Uh oh!

Conversation

AndyAyersMS commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

azure-pipelinesBot commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

EgorBo commented Feb 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

jkotas commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

EgorBo commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

azure-pipelinesBot commented Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

AndyAyersMS commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

azure-pipelinesBot commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

EgorBo commented Feb 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

jkotas commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

EgorBo commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025

Uh oh!

azure-pipelinesBot commented Feb 3, 2025

Uh oh!

AndyAyersMS commented Feb 3, 2025•
edited
Loading

AndyAyersMS commented Feb 3, 2025•
edited
Loading

AndyAyersMS commented Feb 3, 2025•
edited
Loading

AndyAyersMS commented Feb 3, 2025•
edited
Loading

AndyAyersMS commented Feb 3, 2025•
edited
Loading

AndyAyersMS commented Feb 3, 2025•
edited
Loading