JIT: Transform single-reg args to FIELD_LIST in physical promotion by jakobbotsch · Pull Request #111590 · dotnet/runtime

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

jakobbotsch · 2025-01-19T16:42:11Z

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers.

Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

This extends #104370 to handle the remaining cases.

Extend the support for struct arguments in physical promotion to support transforming single-reg structs into a single-field FIELD_LIST node. This allows physically promoted struct arguments passed in a single register to stay in registers. Morph strips the FIELD_LIST in this particular case to match its standard (type-mismatched) representation for single-reg structs. We could produce this IR directly in physical promotion too, but that hits asserts due to type mismatches. Long term we might consider switching to uniformly use FIELD_LIST for structs to avoid the type mismatches we see today.

dotnet-policy-service · 2025-01-19T16:42:45Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch · 2025-01-19T16:44:49Z

 Replacement* rep = nullptr;
 if (agg->OverlappingReplacements(argNode->GetLclOffs() + seg.Offset, seg.Size, &rep, nullptr) &&
- rep->NeedsWriteBack)
+!rep->NeedsReadBack)


The previous check was conservative. It is possible for both NeedsWriteBack and NeedsReadBack to be false, in which case both the struct base local and replacement local are up to date; in that case we should prefer the value from the replacement local. This is the right check for that.

jakobbotsch · 2025-01-23T22:33:35Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-jit-experimental

azure-pipelines · 2025-01-23T22:33:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jakobbotsch · 2025-01-31T15:10:39Z

Failures look like #111777 and #111625.

cc @dotnet/jit-contrib PTAL @EgorBo

Diffs, diffs with old promotion disabled. Another step towards making physical promotion able to handle all the same cases as old promotion.

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 19, 2025

dotnet-policy-serviceBot assigned jakobbotsch Jan 19, 2025

jakobbotsch commented Jan 19, 2025
View reviewed changes

jakobbotsch added 2 commits January 19, 2025 19:54

Revise check due to TYP_LONG on x86
ebfd49d

Handle implicit byrefs appropriately
b9e3d8a

This was referenced Jan 20, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

Merge branch 'main' into physical-promotion-single-reg-struct-args
2e245db

jakobbotsch marked this pull request as ready for review January 23, 2025 22:32

jakobbotsch requested a review from EgorBo January 31, 2025 15:11

EgorBo approved these changes Feb 1, 2025
View reviewed changes

jakobbotsch merged commit 5cc9467 into dotnet:mainFeb 1, 2025

jakobbotsch deleted the physical-promotion-single-reg-struct-args branch February 1, 2025 21:07

jakobbotsch mentioned this pull request Nov 8, 2024
JIT struct work planned for .NET 10 #109635
Closed
16 tasks

github-actionsBot locked and limited conversation to collaborators Mar 4, 2025