Use double.ConvertToIntegerNative where safe to do in System.Random by tannergooding · Pull Request #112046 · dotnet/runtime

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-31T19:15:10Z

This resolves#108096

tannergooding · 2025-01-31T19:50:19Z

(Thanks Egor! Makes it a lot easier to get the perf numbers shared)

EgorBo · 2025-01-31T20:12:45Z

@EgorBot -amd -arm -profiler --envvars JitDisasm:InversionMutation

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Jobs;usingBenchmarkDotNet.Running;publicclassBenchmarks{privateconstintSeed=100;privatestaticreadonlyint[]Chromosome=newint[59];privatestaticreadonlyRandomRandom=new(Seed);publicBenchmarks(){vargenes=Enumerable.Range(1,59).ToArray();Random.Shuffle(genes);genes.CopyTo(Chromosome.AsSpan());}[Benchmark]publicint[]InversionMutation(){varidx1=0;varidx2=0;varchromosomeLength=Chromosome.Length;while(idx1==idx2){idx1=Random.Next(chromosomeLength);idx2=Random.Next(chromosomeLength);}if(idx1>idx2){(idx1,idx2)=(idx2,idx1);}Array.Reverse(Chromosome,idx1,idx2-idx1+1);returnChromosome;}}

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

Use double.ConvertToIntegerNative where safe to do in System.Random
0ab7026

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 31, 2025

dotnet-policy-serviceBot assigned tannergooding Jan 31, 2025

stephentoub approved these changes Jan 31, 2025
View reviewed changes

EgorBot mentioned this pull request Jan 31, 2025
EgorBot for EgorBo in #112046 EgorBot/runtime-utils#280
Open

EgorBot mentioned this pull request Jan 31, 2025
EgorBot for EgorBo in #112046 EgorBot/runtime-utils#281
Open

build-analysisBot mentioned this pull request Jan 31, 2025
[wasi] wasmtime oom #112014
Closed

tannergooding merged commit bc191c9 into dotnet:mainFeb 1, 2025

tannergooding deleted the fix-108096 branch February 1, 2025 19:03

matouskozak mentioned this pull request Feb 4, 2025
[Perf] Linux/arm64: 5 Regressions on 2/1/2025 11:17:39 PM +00:00 dotnet/perf-autofiling-issues#49586
Closed

jkurdek mentioned this pull request Feb 6, 2025
[Perf] Linux/x64: 33 Regressions on 2/1/2025 7:06:23 PM +00:00 dotnet/perf-autofiling-issues#49606
Closed

radekdoulik mentioned this pull request Feb 6, 2025
[Perf] Linux/x64: 1 Regression on 2/1/2025 7:06:23 PM +00:00 dotnet/perf-autofiling-issues#49709
Open

github-actionsBot locked and limited conversation to collaborators Mar 4, 2025