Ensure that math calls into the CRT are tracked as needing vzeroupper by tannergooding · Pull Request #112011 · dotnet/runtime

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

tannergooding · 2025-01-30T19:04:51Z

The root issue was that GenTreeCall::NeedsVzeroupper was only looking at IsPInvoke() methods, while calls like Math.Sin are represented as regular CT_USERCALL, thus we lost track of the fact that this was not actually in managed.

This then resolves#111016 by ensuring that we correctly mark such calls as being "special" (via GTF_CALL_M_SPECIAL_INTRINSIC) which then allows us to decide to do the additional signature checking and determine that a vzeroupper is needed.

If any of these calls are later moved to managed, then we can avoid the vzeroupper by not marking these particular cases as "special". This already applies to cases like Sqrt which are never rewritten back as user calls or cases like Max where we know the fallback is in managed, rather than into the C runtime.

tannergooding · 2025-01-31T18:43:53Z

CC. @dotnet/jit-contrib for review

* main: System.Net.Http.WinHttpHandler.StartRequestAsync assertion failed (dotnet#109799) Keep test PDB in helix payload for native AOT (dotnet#111949) Build the RID-specific System.IO.Ports packages in the VMR (dotnet#112054) Always inline number conversions (dotnet#112061) Use Contains{Any} in Regex source generator (dotnet#112065) Update dependencies from https://github.com/dotnet/arcade build 20250130.5 (dotnet#112013) JIT: Transform single-reg args to FIELD_LIST in physical promotion (dotnet#111590) Ensure that math calls into the CRT are tracked as needing vzeroupper (dotnet#112011) Use double.ConvertToIntegerNative where safe to do in System.Random (dotnet#112046) JIT: Compute `fgCalledCount` after synthesis (dotnet#112041) Simplify boolean logic in `TimeZoneInfo` (dotnet#112062) JIT: Update type when return temp is freshly created (dotnet#111948) Remove unused build controls and simplify DotNetBuild.props (dotnet#111986) Fix case-insensitive JSON deserialization of enum member names (dotnet#112028) WasmAppBuilder: Remove double computation of a value (dotnet#112047) Disable LTCG for brotli and zlibng. (dotnet#111805) JIT: Improve x86 unsigned to floating cast codegen (dotnet#111595) simplify x86 special intrinsic imports (dotnet#111836) JIT: Try to retain entry weight during profile synthesis (dotnet#111971) Fix explicit offset of ByRefLike fields. (dotnet#111584)

Ensure that math calls into the CRT are tracked as needing vzeroupper
cbaed82

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 30, 2025

dotnet-policy-serviceBot assigned tannergooding Jan 30, 2025

PranavSenthilnathan reviewed Jan 30, 2025
View reviewed changes

Comment threadsrc/coreclr/jit/gentree.cpp

build-analysisBot mentioned this pull request Jan 31, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
3 tasks

tannergooding commented Jan 31, 2025
View reviewed changes

Comment threadsrc/coreclr/jit/gentree.cpp Outdated

Apply suggestions from code review
34fe382

BruceForstall approved these changes Jan 31, 2025
View reviewed changes

Don't force vzeroupper for helpers written in managed
1565f2b

tannergooding force-pushed the fix-111016 branch from a508a99 to 1565f2bCompare January 31, 2025 22:11

build-analysisBot mentioned this pull request Feb 1, 2025
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
3 tasks

tannergooding merged commit 6f221b4 into dotnet:mainFeb 1, 2025

tannergooding deleted the fix-111016 branch February 1, 2025 19:06

LoopedBard3 mentioned this pull request Feb 4, 2025
[Perf] Linux/x64: 25 Regressions on 2/1/2025 7:06:23 PM +00:00 #112133
Closed

github-actionsBot locked and limited conversation to collaborators Mar 4, 2025