Skip to content

[wasm][debugger] Implement support to DebuggerDisplay attribute - #55524

Merged
thaystg merged 6 commits into
dotnet:mainfrom
thaystg:thays_support_debugger_custom_views
Jul 14, 2021
Merged

[wasm][debugger] Implement support to DebuggerDisplay attribute#55524
thaystg merged 6 commits into
dotnet:mainfrom
thaystg:thays_support_debugger_custom_views

Conversation

@thaystg

@thaystgthaystg commented Jul 12, 2021•
edited
Loading

Copy link
Copy Markdown
Member

image

@thaystg
thaystg requested review from lewing and radicalJuly 12, 2021 17:47
@ghost

ghost commented Jul 12, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Waiting for merge of #55458 to continue the implementation using method call.

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystgthaystg added the arch-wasm WebAssembly architecture label Jul 12, 2021
@thaystgthaystg linked an issue Jul 12, 2021 that may be closed by this pull request
[Blazor/WASM] Unable to enumerate over IEnumerable in the Watch Window #49442
Closed
@thaystg
Merge branch 'main' of github.com:thaystg/runtime into thays_support_…
a8fb8cf
…debugger_custom_views
* 'main' of github.com:thaystg/runtime: (125 commits)
[wasm] [debugger] Support method calls (dotnet#55458)
[debugger] Fix debugging after hot reloading (dotnet#55599)
Inliner: Extend IL limit for profiled call-sites, allow inlining for switches. (dotnet#55478)
DiagnosticSourceEventSource supports base class properties (dotnet#55613)
[mono] Fix race during mono_image_storage_open (dotnet#55201)
[mono] Add wrapper info for native func wrappers. (dotnet#55602)
H/3 and Quic AppContext switch (dotnet#55332)
Compression.ZipFile support for Unix Permissions (dotnet#55531)
[mono] Fix skipping of static methods during IMT table construction. (dotnet#55610)
Combine System.Private.Xml TrimmingTests projects (dotnet#55606)
fix name conflict with Configuration class (dotnet#55597)
Finish migrating RSAOpenSsl from RSA* to EVP_PKEY*
Disable generic math (dotnet#55540)
Obsolete CryptoConfig.EncodeOID (dotnet#55592)
Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp (dotnet#54995)
Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled (dotnet#55572)
Fix Task.WhenAny failure mode when passed ICollection of zero tasks (dotnet#55580)
Consume DistributedContextPropagator in DiagnosticsHandler (dotnet#55392)
Add property ordering feature (dotnet#55586)
Reduce subtest count in Reflection (dotnet#55537)
...
@thaystg
Implementing DebuggerDisplay calling methods.
58c0108
@thaystg
thaystg marked this pull request as ready for review July 14, 2021 14:01
lewing
lewing approved these changes Jul 14, 2021
View reviewed changes

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than snake case

lewing
lewing reviewed Jul 14, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/DebuggerTestSuite/CustomViewTests.cs Outdated
Comment threadsrc/mono/wasm/debugger/tests/debugger-test/debugger-custom-view-test.cs Outdated
Comment threadsrc/mono/wasm/debugger/tests/debugger-test/debugger-custom-view-test.cs Outdated
Comment threadsrc/mono/wasm/debugger/tests/debugger-test/debugger-custom-view-test.cs Outdated
thaystgand others added 2 commits July 14, 2021 08:12
@thaystg@lewing
Apply suggestions from code review
fa91a1e
Co-authored-by: Larry Ewing <lewing@microsoft.com>
@thaystg
Fixing snake case.
c55c8b0
@thaystg

thaystg commented Jul 14, 2021

Copy link
Copy Markdown
MemberAuthor

Looks good other than snake case

Fixed snake case.

@lewing

lewing commented Jul 14, 2021

Copy link
Copy Markdown
Member

fixes #46859

@thaystg
thaystg merged commit 44f7103 into dotnet:mainJul 14, 2021
@lewinglewing mentioned this pull request Jul 14, 2021
Closed
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@radicalradicalAwaiting requested review from radical
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Blazor/WASM] Unable to enumerate over IEnumerable in the Watch Window

2 participants

@thaystg@lewing