Uh oh!
There was an error while loading. Please reload this page.
Revert "Update assembly version from hardcoded to MajorVersion" - #77899
Merged
Conversation
ghost
commented
Nov 4, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
radical
approved these changes
Nov 4, 2022
radical
commented
Nov 4, 2022
Member
/azp run runtime-wasm-perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 4, 2022
Member
The This is likely related to dotnet/performance#2585 . But also see #77883 (comment) for related context. |
ViktorHofer
approved these changes
Nov 7, 2022
carlossanlop
commented
Nov 7, 2022
Contributor
Since I got both sign-offs I will merge. |
This was referenced Nov 7, 2022
rainersigwald added a commit
to rainersigwald/wpf
that referenced
this pull request
Dec 1, 2022
The 8.0.100-alpha.1.22512.5 SDK was built in a window where System references were versioned `8.0.0.0`, but in a way that broke some things. That was backed out in dotnet/runtime#77899, which means that assemblies built from this repo can't run on the current .NET 8 runtime, which cannot satisfy a dependency on, for example, `System.Runtime, Version=8.0.0.0`. Move forward to a newer .NET 8 that has those assemblies versioned at `7.0.0.0` again, which should work even when dotnet/runtime#78354 bumps the version again, because the loader will accept higher versions.
dreddy-work pushed a commit
to dotnet/wpf
that referenced
this pull request
Dec 1, 2022
The 8.0.100-alpha.1.22512.5 SDK was built in a window where System references were versioned `8.0.0.0`, but in a way that broke some things. That was backed out in dotnet/runtime#77899, which means that assemblies built from this repo can't run on the current .NET 8 runtime, which cannot satisfy a dependency on, for example, `System.Runtime, Version=8.0.0.0`. Move forward to a newer .NET 8 that has those assemblies versioned at `7.0.0.0` again, which should work even when dotnet/runtime#78354 bumps the version again, because the loader will accept higher versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #74157
Changing assembly versions without changing the TargetFramework represented by those assemblies is causing any consuming assembly in packages that target
net7.0to have references to 8.0 versioned assemblies. This will break the consumption of those packages.For this change to work, it cannot change referenced versions that are exposed as
net7.0. The TFM targeted by packages can likely change before AssemblyVersion, but not vice-versa.