Skip to content

Revert "Remove "wprintf" from PAL (#77852)" - #77913

Closed
radical wants to merge 1 commit into
dotnet:mainfrom
radical:revert-wprintf
Closed

Revert "Remove "wprintf" from PAL (#77852)"#77913
radical wants to merge 1 commit into
dotnet:mainfrom
radical:revert-wprintf

Conversation

@radical

Copy link
Copy Markdown
Member

This completely broke dotnet-runtime-perf pipeline for wasm runs.

This reverts commit 8036885.

Issue: #77883

This completely broke `dotnet-runtime-perf` pipeline for wasm runs.
This reverts commit 8036885.
Issue: dotnet#77883
@radicalradical added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Regression perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Nov 4, 2022
@ghostghost added the area-PAL-coreclr only for closed issues label Nov 4, 2022
@ghostghost assigned radicalNov 4, 2022
@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

@radical It would be most helpful if you could root out what part of WASM is failing and potential reproduction steps here.

@radical

Copy link
Copy Markdown
MemberAuthor

@radical It would be most helpful if you could root out what part of WASM is failing and potential reproduction steps here.

I was was able to confirm that this is only happening for wasm. So, I'm trying to check if anything else could be responsible here.

@radical

Copy link
Copy Markdown
MemberAuthor
  • I tested with your commit intact
  • Between the two CI runs:

cc @LoopedBard3@ericstj

@AaronRobinsonMSFT this looks completely unrelated to your PR 👍

@radical
radical removed the request for review from AaronRobinsonMSFTNovember 4, 2022 20:44
@radicalradical closed this Nov 4, 2022
@radical
radical deleted the revert-wprintf branch November 4, 2022 20:46
@ghostghost locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclronly for closed issuesblocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'perf-pipelineIssues with dotnet-runtime-perf, or runtime-wasm-perf pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@radical@AaronRobinsonMSFT@jeffhandley