Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Suppress clang-16 warnings (backport #81573) - #84443
Merged
carlossanlop merged 2 commits intoMay 15, 2023
Merged
Conversation
am11
commented
Apr 6, 2023
Member
Backport #82461 at the same time? |
ayakaelforce-pushed
the
backport/pr-81573-to-release/6.0
branch
from
April 6, 2023 20:40
8a26995 to
a6d9fbfCompareayakaelforce-pushed
the
backport/pr-81573-to-release/6.0
branch
from
April 6, 2023 21:10
a6d9fbf to
db09bc2Compareayakael
requested review from
eiriktsarpalis, lambdageek, layomia, steveharter, thaystg and vargaz
as code ownersApril 6, 2023 21:10
This was referenced Apr 7, 2023
carlossanlop
commented
Apr 10, 2023
Contributor
cc @tommcdon (see #84444 (comment)) |
ghost
commented
Apr 11, 2023
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsCustomer impactWithout this, .NET 6 fails to build on platforms that use clang-16 TestingTested on CI and manually on Alpine Linux edge. RiskLow. The flag that is set makes the compiler less strict.
|
hoyosjs
approved these changes
Apr 11, 2023
Contributor
@mikem8361, @hoyosjs - if we want this change in the June Release, and it looks ready, please merge before May 15th (Code Complete). |
hoyosjs
approved these changes
May 4, 2023
am11
commented
May 4, 2023
Member
Failures look related. |
hoyosjs
requested changes
May 5, 2023
Uh oh!
There was an error while loading. Please reload this page.
ayakaelforce-pushed
the
backport/pr-81573-to-release/6.0
branch
from
May 5, 2023 04:31
db09bc2 to
ac85cafCompareakoeplinger
approved these changes
May 5, 2023
akoeplinger
commented
May 5, 2023
Member
Failures look unrelated to me now. |
This was referenced May 5, 2023
carlossanlop
commented
May 15, 2023
Contributor
Today is code complete for the June Release. @hoyosjs@akoeplinger is this ready to merge? @hoyosjs you have a blocking review. |
hoyosjs
approved these changes
May 15, 2023
akoeplinger
commented
May 15, 2023
Member
@carlossanlop this is ready 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #81573 and #82461
Customer impact
Without this, .NET 6 fails to build on platforms that use clang-16
Testing
Tested on CI and manually on Alpine Linux edge.
Risk
Low. The flag that is set makes the compiler less strict.
@am11@omajid ptal.