') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/7.0] Suppress clang-16 warnings (backport #81573) by ayakael · Pull Request #84444 · dotnet/runtime · GitHub
Skip to content

[release/7.0] Suppress clang-16 warnings (backport #81573) - #84444

Merged
akoeplinger merged 2 commits into
dotnet:release/7.0-stagingfrom
ayakael:backport/pr-81573-to-release/7.0
May 15, 2023
Merged

[release/7.0] Suppress clang-16 warnings (backport #81573)#84444
akoeplinger merged 2 commits into
dotnet:release/7.0-stagingfrom
ayakael:backport/pr-81573-to-release/7.0

Conversation

@ayakael

@ayakaelayakael commented Apr 6, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Backports #81573 and #82461

Customer impact

Without this, .NET 7 fails to build on platforms that use clang-16

Testing

Tested on CI and manually on Alpine Linux edge.

Risk

Low. The flag that is set makes the compiler less strict.

@am11@omajid ptal.

@ghostghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners community-contribution Indicates that the PR has been added by a community member labels Apr 6, 2023
@ayakaelayakael changed the title [release/7.0] Suppress-clang-16 warnings[release/7.0] Suppress clang-16 warningsApr 6, 2023
@ayakaelayakael changed the title [release/7.0] Suppress clang-16 warnings[release/7.0] Suppress clang-16 warnings (backport #81573)Apr 6, 2023
@am11

am11 commented Apr 6, 2023

Copy link
Copy Markdown
Member

It needs the DBI fix: #82461.

am11
am11 reviewed Apr 6, 2023
View reviewed changes
Comment threadeng/common/native/init-compiler.sh Outdated
@ayakael
ayakaelforce-pushed the backport/pr-81573-to-release/7.0 branch 2 times, most recently from 60dfa30 to b5b3114CompareApril 6, 2023 20:38
@ayakaelayakael mentioned this pull request Apr 6, 2023
Merged
@ayakael

ayakael commented Apr 6, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

It needs the DBI fix: #82461.

Done :)

@ayakaelayakael closed this Apr 6, 2023
@ayakaelayakael reopened this Apr 6, 2023
@am11

am11 commented Apr 6, 2023

Copy link
Copy Markdown
Member
- Backports https://github.com/dotnet/runtime/pull/81573+ Backports https://github.com/dotnet/runtime/pull/81573 and https://github.com/dotnet/runtime/pull/82461

Otherwise, LGTM. 👍

cc @mikem8361

@am11

am11 commented Apr 6, 2023

Copy link
Copy Markdown
Member

The backport workflow has changed. I think this PR should target release/7.0-staging and #84443 should target release/6.0-staging.

See:

runtime/.github/workflows/backport.yml

Line 33 in 531bf3c

- The PR target branch is `release/X.0-staging`, not `release/X.0`.

@ayakael
ayakaelforce-pushed the backport/pr-81573-to-release/7.0 branch from 7cce9c8 to 231f88fCompareApril 6, 2023 21:08
@ayakael
ayakael changed the base branch from release/7.0 to release/7.0-stagingApril 6, 2023 21:08
@ayakaelayakael changed the title [release/7.0] Suppress clang-16 warnings (backport #81573)[release/7.0-staging] Suppress clang-16 warnings (backport #81573)Apr 6, 2023
@ayakaelayakael changed the title [release/7.0-staging] Suppress clang-16 warnings (backport #81573)[release/7.0] Suppress clang-16 warnings (backport #81573)Apr 6, 2023
@carlossanlop

carlossanlop commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

@jeffschwMSFT do you know who can help champion this? Today is code complete for the May release. If we want to include this change in that release, we would need it to be ready to merge by 4pm PT today:

  • Approved by Tactics if this is ask-mode.
  • CI failures determined as unrelated.
  • Signed-off by an area owner.
  • No OOB changes needed since it's not affecting managed libraries code.

@jeffschwMSFT

jeffschwMSFT commented Apr 10, 2023

Copy link
Copy Markdown
Member

@tommcdon can you take a look and request folks to code review? Let's plan on having ready for review in tactics on Tue.

@carlossanlopcarlossanlop mentioned this pull request Apr 10, 2023
Merged
hoyosjs
hoyosjs approved these changes Apr 10, 2023
View reviewed changes

@hoyosjshoyosjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM

Comment threadeng/native/configurecompiler.cmake
# other clang 16.0 suppressions
add_compile_options(-Wno-single-bit-bitfield-constant-conversion)
add_compile_options(-Wno-cast-function-type-strict)
add_compile_options(-Wno-incompatible-function-pointer-types-strict)

@hoyosjshoyosjsApr 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what needs this? I can't seem to find this needed in any other place. I also didn't see it on lld's man page.

@ayakaelayakaelApr 10, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came up when trying to build on Alpine Linux with clang 16. I reported it in #81577 to not forget to investigate.

@jeffschwMSFTjeffschwMSFT added the Servicing-consider Issue for next servicing release review label Apr 10, 2023
@jeffschwMSFTjeffschwMSFT added this to the 7.0.x milestone Apr 10, 2023
@jeffschwMSFT

jeffschwMSFT commented Apr 10, 2023

Copy link
Copy Markdown
Member

do we understand the ci failures?

@hoyosjs

hoyosjs commented Apr 10, 2023

Copy link
Copy Markdown
Member

A fair amount of them are #80619. Analysis is hard because of dotnet/arcade#13066

@JulieLeeMSFTJulieLeeMSFT mentioned this pull request Apr 10, 2023
Merged
@tommcdon
tommcdon requested a review from agockeApril 10, 2023 21:48
@tommcdon

tommcdon commented Apr 10, 2023

Copy link
Copy Markdown
Member

Adding @agocke for the nativeaot related changes

@am11

am11 commented Apr 11, 2023

Copy link
Copy Markdown
Member

Adding @agocke for the nativeaot related changes

There is no NativeAOT change in this PR. :)

@tommcdon

tommcdon commented Apr 11, 2023

Copy link
Copy Markdown
Member

Adding @agocke for the nativeaot related changes

There is no NativeAOT change in this PR. :)

Ahh yes, thanks for pointing that out @am11! I meant native corehost, not native aot :).

@danmoseleydanmoseley added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 11, 2023
@ghost

ghost commented Apr 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backports #81573 and #82461

Customer impact

Without this, .NET 7 fails to build on platforms that use clang-16

Testing

Tested on CI and manually on Alpine Linux edge.

Risk

Low. The flag that is set makes the compiler less strict.

@am11@omajid ptal.

Author:ayakael
Assignees:-
Labels:

Servicing-consider, area-Infrastructure, community-contribution

Milestone:7.0.x

@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 11, 2023
@leecowleecow modified the milestones: 7.0.x, 7.0.7Apr 11, 2023
@carlossanlop

carlossanlop commented May 15, 2023

Copy link
Copy Markdown
Contributor

Hey all, today is Code Complete for the June Release. If this good to merge, please help merge the PR. @agocke, @hoyosjs@mikem8361 .

@akoeplinger
akoeplinger merged commit 6f9d91c into dotnet:release/7.0-stagingMay 15, 2023
@radicalradical mentioned this pull request Jun 15, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystg
@marek-safarmarek-safarAwaiting requested review from marek-safar
@mikem8361mikem8361Awaiting requested review from mikem8361
@agockeagockeAwaiting requested review from agocke
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community memberServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.7

Development

Successfully merging this pull request may close these issues.

9 participants

@ayakael@am11@carlossanlop@jeffschwMSFT@hoyosjs@tommcdon@akoeplinger@leecow@danmoseley