Skip to content

[release/8.0] Update dependencies from dotnet/roslyn - #91482

Merged
carlossanlop merged 35 commits into
release/8.0from
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged

[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Sep 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost added the area-codeflow for labeling automated codeflow label Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot mentioned this pull request Sep 7, 2023
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8
This was referenced Sep 8, 2023
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7
This was referenced Sep 9, 2023
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot mentioned this pull request Sep 9, 2023
Open
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot mentioned this pull request Sep 10, 2023
Closed
@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Sep 11, 2023
@carlossanlop
carlossanlop merged commit 282da2c into release/8.0Sep 11, 2023
@carlossanlop
carlossanlop deleted the darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1 branch September 11, 2023 22:38
@ericstj

ericstj commented Sep 13, 2023

Copy link
Copy Markdown
Member

I think this PR introduced failures in CI. After this was merged we're seeing failures like:

System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit that referenced this pull request Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj

ericstj commented Sep 13, 2023

Copy link
Copy Markdown
Member

@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
Merged
Closed
@steveharter

steveharter commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850

@ericstj

ericstj commented Sep 13, 2023

Copy link
Copy Markdown
Member

Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.

@ericstj

ericstj commented Sep 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?

@steveharter

steveharter commented Sep 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:

runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409 in 32d2bcd

publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.

@carlossanlop

carlossanlop commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850

Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.

image

carlossanlop added a commit that referenced this pull request Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj

ericstj commented Sep 13, 2023

Copy link
Copy Markdown
Member

Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:

runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409 in 32d2bcd

publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.

@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.

@radicalradical mentioned this pull request Sep 26, 2023
Closed
@radicalradical mentioned this pull request Oct 3, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[release/8.0] Update dependencies from dotnet/roslyn by dotnet-maestro[bot] · Pull Request #91482 · dotnet/runtime · GitHub
Skip to content
[release/8.0] Update dependencies from dotnet/roslyn - #91482
Merged
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Sep 11, 2023
Merged
[release/8.0] Update dependencies from dotnet/roslyn#91482
carlossanlop merged 35 commits into
release/8.0from 
darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
  • Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
  • Build: 20230909.2
  • Date Produced: September 10, 2023 5:42:35 AM UTC
  • Commit: d080175cabfe297ebf079af099279b61913bcc28
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ebe22b5
…901.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Sep 1, 2023
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
273007e
…901.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a55d832
…901.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild2023090…
cf87949
….1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
61db12b
…905.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
25aaf07
…905.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ab91843
…905.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
22fc4b6
…905.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1b4a022
…905.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a7dc69a
…906.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
80cd954
…906.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b5338d2
…906.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
f20eb04
…906.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
83ba391
…906.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5688e36
…906.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2d378ab
…906.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
1c8c76b
…906.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2eac082
…906.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
00f44a9
…906.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
aa8ad66
…907.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
b821167
…907.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
7b2c530
…907.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
4fcaddc
…907.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ee9069b
…907.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
169c138
…907.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
319eec1
…907.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

This was referenced Sep 8, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
91561cc
…908.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
95d0b00
…908.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
2969228
…908.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
8928da6
…908.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

This was referenced Sep 9, 2023

Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
5b6ffcd
…908.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 9, 2023

Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
ca7e98b
…909.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
a245568
…909.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 10, 2023

Closed

@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 11, 2023
@carlossanlop
carlossanlop
merged commit 282da2c
into
release/8.0Sep 11, 2023
@carlossanlop
carlossanlop
deleted the

darc-release/8.0-5ef0b5b6-3382-40bf-bfb4-2b8820a236e1

branch
September 11, 2023 22:38
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
I think this PR introduced failures in CI. After this was merged we're seeing failures like:
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)"
3ef419d
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
@carlossanlop will back this out and we'll address the problem in #91913

This was referenced Sep 13, 2023
 Merged


Closed

@steveharter
steveharter
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.
@ericstj
ericstj
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?
@steveharter
steveharter
commented
Sep 13, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.
@carlossanlop
carlossanlop
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850
Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.
image
carlossanlop added a commit
that referenced
this pull request
Sep 13, 2023
@carlossanlop
Revert "[release/8.0] Update dependencies from dotnet/roslyn (#91482)" (
d34a059
#92011)
This reverts commit 282da2c.
@ericstj
ericstj
commented
Sep 13, 2023

Copy link


Copy Markdown

Member
Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:
runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409
in
32d2bcd
publicoverrideTypeAttributesAttributes=>TypeAttributes.AutoLayout|TypeAttributes.AnsiClass|TypeAttributes.Class|TypeAttributes.Public|TypeAttributes.ClassSemanticsMask|TypeAttributes.Abstract;
or just remove that LOC since the base class has the same implementation for that virtual property.
@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.
@radicalradical
mentioned this pull request
Sep 26, 2023
 Closed

@radicalradical
mentioned this pull request
Oct 3, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj@steveharter@carlossanlop