Uh oh!
There was an error while loading. Please reload this page.
Drop deprecates - #3071
Conversation
9ae5b3b to
4e67f08Comparefb8805a to
3dcc429CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Jan 25, 2024
Great. Needs a |
T-256
commented
Jan 25, 2024
The purpose of this is for v1.0 I thought #3069 will include changelogs. For example for this PR:
@tomchristie Do any docs need to be updated? |
lovelydinosaur
commented
Jan 25, 2024
My feeling is that we should push on with 1.0. (Tho I also think that this particular change would be acceptable even in 0.27 release, since it's only removing features that are already formally deprecated.) |
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Jan 25, 2024
Neat.
For this PR just the |
| * Recently deprecated `proxies` argument has been removed. (#3071) | ||
| * Per request `cookies` argument is not supporting anymore. (#3071) | ||
| * Non-Mapping objects for `data` argument is no longer allowed. (#3071) |
There was a problem hiding this comment.
I'd suggest we limit the pull request to just one line item here, and deal with the proxies case.
rafalkrupinski
commented
Jan 30, 2024
Please don't remove per-request cookies :) |
lovelydinosaur
commented
Jan 30, 2024
Targeting just the |
T-256
commented
Feb 2, 2024
I ended up to not drop any public api before major release. |
vmatt
commented
Feb 13, 2025
FYI, one uscase: for my unit tests, i need to have dynamic cookie setting (as I impersonate different users. Legacy system auth is based on cookies not bearer) |
Summary
version 1.0 proposal
Resolves requirements for #3069 (review)
Checklist