Uh oh!
There was an error while loading. Please reload this page.
reg_field: add field_relax device dispatch + bump cpu/cuda pins - #36
Merged
Merged
Conversation
Wire `field_relax` through the device-dispatch boundary: inspects `sol.device.device_type` and forwards to `FF_CUDA::field_relax` (guarded by FF_WITH_CUDA) or `FF_CPU::field_relax`, mirroring the existing `flow_relax` dispatch. Declared in reg_field.h with the same signature as the CPU/CUDA libraries (sol/hes/grd tensors, per-channel penalty vectors, bound/ndim/nb_iter/stream). Bump submodule pins to the commits that add field_relax on each backend: cpu -> fastfields-cpu-lib#37, cuda -> fastfields-cuda-lib#23. Verified: `make all CXX=clang++` builds libfastfields-cpu.so and libfastfields.so clean; the cpu-lib test suite passes in full (11 modules, 0 failures, including reg_field's 463 checks). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
balbasty added a commit
that referenced
this pull request
Jul 27, 2026
The previous pin-bump commit (#36) accidentally committed the dev-tree's working-tree symlinks (`cpu -> ../fastfields-cpu-lib`, `cuda -> ../fastfields-cuda-lib`, used locally so the include chain resolves) in place of the tracked submodule gitlinks, turning `cpu`/`cuda` from 160000 (commit/gitlink) entries into 120000 (plain symlink) blobs. A fresh clone + `git submodule update` would silently fail to check out either backend. Restore both as proper gitlinks, bumping them to the current cpu-lib/ cuda-lib main tips (which also pulls in the field_relax pin-cascade fixes and the RLS/JRLS CUHOST launchers) while doing so. Verified: `make all CXX=clang++` builds libfastfields-cpu.so and libfastfields.so clean. Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires
field_relax(in-place Gauss-Seidel relaxation for the field regulariser) through the device-dispatch boundary, mirroring the existingflow_relaxdispatch:sol.device.device_typeand forwards toFF_CUDA::field_relax(guarded byFF_WITH_CUDA) orFF_CPU::field_relax.reg_field.hwith the same signature as the CPU/CUDA libraries:sol/hes/grdtensors, per-channel penalty vectors (absolute/membrane/bending),bound/ndim/nb_iter/stream.field_relaxon each backend:cpu→ fastfields-cpu-lib#37,cuda→ fastfields-cuda-lib#23.This completes the
field_relaxcascade through the C++/CUDA stack (kernels already had the device relax kernels; cpu-impl/cpu-lib and cuda-impl/cuda-lib are now merged; this is the last native layer before bind-py).Testing
make all CXX=clang++buildslibfastfields-cpu.soandlibfastfields.soclean.test_reg_field: 463 checks, 0 failures).fastfields-cuda-lib'sreg_field.cppunder nvcc in the two merged upstream PRs.🤖 Generated with Claude Code
Generated by Claude Code