Uh oh!
There was an error while loading. Please reload this page.
fix(deps): restore cpu/cuda as real submodule gitlinks + bump pins - #38
Merged
Merged
Conversation
The previous pin-bump commit (#36) accidentally committed the dev-tree's working-tree symlinks (`cpu -> ../fastfields-cpu-lib`, `cuda -> ../fastfields-cuda-lib`, used locally so the include chain resolves) in place of the tracked submodule gitlinks, turning `cpu`/`cuda` from 160000 (commit/gitlink) entries into 120000 (plain symlink) blobs. A fresh clone + `git submodule update` would silently fail to check out either backend. Restore both as proper gitlinks, bumping them to the current cpu-lib/ cuda-lib main tips (which also pulls in the field_relax pin-cascade fixes and the RLS/JRLS CUHOST launchers) while doing so. Verified: `make all CXX=clang++` builds libfastfields-cpu.so and libfastfields.so clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a submodule-tracking regression introduced by the previous pin-bump merge (#36):
cpuandcudawere accidentally committed as plain symlink blobs (mode120000, content../fastfields-cpu-lib/../fastfields-cuda-lib— the dev-tree's local working-tree convenience symlinks) instead of proper submodule gitlinks (mode160000, a commit reference). A fresh clone followed bygit submodule updatewould silently fail to check out either backend, since there's no commit reference to resolve.cpu/cudaas real160000gitlinks.cpu→ fastfields-cpu-lib main (pulls in thematvec_lame_jrlsself-adjointness fix),cuda→ fastfields-cuda-lib main (pulls in the RLS/JRLS CUHOST launchers + the same fix).Testing
make all CXX=clang++buildslibfastfields-cpu.soandlibfastfields.soclean.🤖 Generated with Claude Code
Generated by Claude Code