Uh oh!
There was an error while loading. Please reload this page.
ci: make clang-format non-blocking in lint workflow - #51
Merged
Conversation
balbasty
commented
Aug 2, 2026
CollaboratorAuthor
Review summary (triage, jitfields-to-fastfields): merged as squash. Same mechanical change as the other 5 repos in this batch ( Workstream: claude-jitfields-to-fastfields Generated by Claude Code |
balbasty added a commit
that referenced
this pull request
Aug 5, 2026
Picks up fastfields-cpu-lib#82, which bumps fastfields-cpu-impl to #69's fix for #51 (relax_bending_rls_/relax_bending_jrls_ used a 2*niter colour-loop bound instead of pow<ndim>(3)*niter, leaving most of the field unrelaxed for bending-order RLS/JRLS relaxation) and adds a deterministic regression test for it. part of #33 Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: trueat theclang-formatjob level in.github/workflows/lint.yamlso the job keeps running and reporting on every PR but no longer fails the overall required check.codespellis untouched and remains blocking.git-clang-format-18, extension list) and thecodespelljob are untouched.continue-on-error, without altering the existing explanation of why it's diff-scoped.Test plan
Lintworkflow runs on this PR.codespellstill runs and blocks as before.clang-formatruns and, if it finds violations, is shown as a non-blocking failure (does not fail the required check) rather than a hard failure.Workstream: claude-jitfields-to-fastfields
🤖 Generated with Claude Code
Generated by Claude Code